[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 32/38] migration/ram: Remove RAMState from xbzrle_cache_zero_page
From: |
Juan Quintela |
Subject: |
[PULL 32/38] migration/ram: Remove RAMState from xbzrle_cache_zero_page |
Date: |
Mon, 16 Oct 2023 12:07:00 +0200 |
From: Fabiano Rosas <farosas@suse.de>
'rs' is not used in that function. It's a leftover from commit
9360447d34 ("ram: Use MigrationStats for statistics").
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20231011184604.32364-4-farosas@suse.de>
---
migration/ram.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 2bd51d6bb5..535172d9be 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -570,7 +570,6 @@ void mig_throttle_counter_reset(void)
/**
* xbzrle_cache_zero_page: insert a zero page in the XBZRLE cache
*
- * @rs: current RAM state
* @current_addr: address for the zero page
*
* Update the xbzrle cache to reflect a page that's been sent as all 0.
@@ -579,7 +578,7 @@ void mig_throttle_counter_reset(void)
* As a bonus, if the page wasn't in the cache it gets added so that
* when a small write is made into the 0'd page it gets XBZRLE sent.
*/
-static void xbzrle_cache_zero_page(RAMState *rs, ram_addr_t current_addr)
+static void xbzrle_cache_zero_page(ram_addr_t current_addr)
{
/* We don't care if this fails to allocate a new cache page
* as long as it updated an old one */
@@ -2146,7 +2145,7 @@ static int ram_save_target_page_legacy(RAMState *rs,
PageSearchStatus *pss)
*/
if (rs->xbzrle_started) {
XBZRLE_cache_lock();
- xbzrle_cache_zero_page(rs, block->offset + offset);
+ xbzrle_cache_zero_page(block->offset + offset);
XBZRLE_cache_unlock();
}
return res;
--
2.41.0
- [PULL 23/38] migration/rdma: Check sooner if we are in postcopy for save_page(), (continued)
- [PULL 23/38] migration/rdma: Check sooner if we are in postcopy for save_page(), Juan Quintela, 2023/10/16
- [PULL 17/38] migration/rdma: Remove all uses of RAM_CONTROL_HOOK, Juan Quintela, 2023/10/16
- [PULL 24/38] migration/rdma: Use i as for index instead of idx, Juan Quintela, 2023/10/16
- [PULL 21/38] migration/rdma: Move rdma constants from qemu-file.h to rdma.h, Juan Quintela, 2023/10/16
- [PULL 25/38] migration/rdma: Declare for index variables local, Juan Quintela, 2023/10/16
- [PULL 22/38] migration/rdma: Remove qemu_ prefix from exported functions, Juan Quintela, 2023/10/16
- [PULL 26/38] migration/rdma: Remove all "ret" variables that are used only once, Juan Quintela, 2023/10/16
- [PULL 27/38] migration: Improve json and formatting, Juan Quintela, 2023/10/16
- [PULL 28/38] migration: check for rate_limit_max for RATE_LIMIT_DISABLED, Juan Quintela, 2023/10/16
- [PULL 31/38] migration/ram: Refactor precopy ram loading code, Juan Quintela, 2023/10/16
- [PULL 32/38] migration/ram: Remove RAMState from xbzrle_cache_zero_page,
Juan Quintela <=
- [PULL 29/38] multifd: fix counters in multifd_send_thread, Juan Quintela, 2023/10/16
- [PULL 36/38] migration/multifd: Remove direct "socket" references, Juan Quintela, 2023/10/16
- [PULL 30/38] multifd: reset next_packet_len after sending pages, Juan Quintela, 2023/10/16
- [PULL 34/38] migration/ram: Move xbzrle zero page handling into save_zero_page, Juan Quintela, 2023/10/16
- [PULL 37/38] migration/multifd: Unify multifd_send_thread error paths, Juan Quintela, 2023/10/16
- [PULL 33/38] migration/ram: Stop passing QEMUFile around in save_zero_page, Juan Quintela, 2023/10/16
- [PULL 38/38] migration/multifd: Clarify Error usage in multifd_channel_connect, Juan Quintela, 2023/10/16
- [PULL 35/38] migration/ram: Merge save_zero_page functions, Juan Quintela, 2023/10/16
- Re: [PULL 00/38] Migration 20231016 patches, Stefan Hajnoczi, 2023/10/16