qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/11] MAINTAINERS: Add Astro PCI host for hppa machines


From: BALATON Zoltan
Subject: Re: [PATCH v2 04/11] MAINTAINERS: Add Astro PCI host for hppa machines
Date: Tue, 17 Oct 2023 18:19:08 +0200 (CEST)

On Tue, 17 Oct 2023, deller@kernel.org wrote:
From: Helge Deller <deller@gmx.de>

Signed-off-by: Helge Deller <deller@gmx.de>
---
MAINTAINERS | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Is this better squashed in the previous patch adding this device? Then checkpatch won't complain about that and splitting out just this does not make the previous patch simpler so not sure it should be separate patch.

The last line adding seabios is not mentioned in commit message. Is that related ot just a fixup while you're there.

Regards,
BALATON Zoltan

diff --git a/MAINTAINERS b/MAINTAINERS
index ceea4c2bf2..68d086a0f3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1174,7 +1174,7 @@ F: hw/*/etraxfs_*.c

HP-PARISC Machines
------------------
-HP B160L
+HP B160L, HP C3700
M: Richard Henderson <richard.henderson@linaro.org>
R: Helge Deller <deller@gmx.de>
S: Odd Fixes
@@ -1182,11 +1182,14 @@ F: configs/devices/hppa-softmmu/default.mak
F: hw/hppa/
F: hw/net/*i82596*
F: hw/misc/lasi.c
+F: hw/pci-host/astro.c
F: hw/pci-host/dino.c
F: include/hw/misc/lasi.h
F: include/hw/net/lasi_82596.h
+F: include/hw/pci-host/astro.h
F: include/hw/pci-host/dino.h
F: pc-bios/hppa-firmware.img
+F: roms/seabios-hppa/

LoongArch Machines
------------------




reply via email to

[Prev in Thread] Current Thread [Next in Thread]