Re: [RFC PATCH v2 02/78] block: add fallthrough pseudo-keyword

[Manos Pitsidianakis]

On Wed, 18 Oct 2023 01:11, Eric Blake <eblake@redhat.com> wrote:
> >  static bool cluster_needs_new_alloc(BlockDriverState *bs, uint64_t 
> >  l2_entry)
> >  {
> >      switch (qcow2_get_cluster_type(bs, l2_entry)) {
> >      case QCOW2_CLUSTER_NORMAL:
> > +        fallthrough;
> >      case QCOW2_CLUSTER_ZERO_ALLOC:
>
> Why is this one needed?  It looks two case labels for the same code is
> okay; the fallthrough attribute is only needed once a case label is no
> lonter empty.
> ...
> These two also look spurious.
>
> ...
> but these three seem spurious.

Thanks for pointing it out, Eric. Indeed these are mistakes.

By the way, there's a newer version posted [0] because as you noticed I 
accidentally left --function-context on git-format-patch and didn't 
notice that some of them blew up in size.

Also, the consensus in v1 was to reject this patch series in general 
[1].

[0]: <cover.1697186560.git.manos.pitsidianakis@linaro.org> 
cover.1697186560.git.manos.pitsidianakis@linaro.org/">https://lore.kernel.org/qemu-devel/cover.1697186560.git.manos.pitsidianakis@linaro.org/

[1]: 
<CAFEAcA_fLBe9CuWFYpeuejj8dcerhFtPNX+iVaVFvH4SXx1oAg@mail.gmail.com>
CAFEAcA_fLBe9CuWFYpeuejj8dcerhFtPNX+iVaVFvH4SXx1oAg@mail.gmail.com/">https://lore.kernel.org/qemu-devel/CAFEAcA_fLBe9CuWFYpeuejj8dcerhFtPNX+iVaVFvH4SXx1oAg@mail.gmail.com/


--
Manos