Re: [PATCH] hw/cxl: Fix opaque type interpret wrongly

[Zhijian Li (Fujitsu)]

On 13/10/2023 16:52, Philippe Mathieu-Daudé wrote:
> On 13/10/23 03:55, Li Zhijian wrote:
>> void cxl_component_register_block_init(Object *obj,
>>                                         CXLComponentState *cxl_cstate,
>>                                         const char *type)
>> {
>>      ComponentRegisters *cregs = &cxl_cstate->crb;
>> ...
>>      memory_region_init_io(&cregs->cache_mem, obj, &cache_mem_ops, cregs,
>>                            ".cache_mem", CXL2_COMPONENT_CM_REGION_SIZE);
>>
>> Obviously, opaque should be pointer to ComponentRegisters.
>> Fortunately, cregs is the first member of cxl_state, so their values are
>> the same.
>>
>> Fixes: 9e58f52d3f8 ("hw/cxl/component: Introduce CXL components (8.1.x, 
>> 8.2.5)")
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>> ---
>>   hw/cxl/cxl-component-utils.c | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Philippe, thanks for you quickly review, I just post V2 which change the source 
side type
to CXLComponentState because the read/write require it. Please take another 
look.




>