[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/11] migration: Simplify decompress_data_with_multi_threads()
From: |
Juan Quintela |
Subject: |
[PULL 06/11] migration: Simplify decompress_data_with_multi_threads() |
Date: |
Wed, 18 Oct 2023 12:06:46 +0200 |
Doing a break to do another break is just confused. Just call return
when we know we want to return.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Message-ID: <20230613145757.10131-14-quintela@redhat.com>
---
migration/ram-compress.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/migration/ram-compress.c b/migration/ram-compress.c
index 3ad5975d48..95a8d6b906 100644
--- a/migration/ram-compress.c
+++ b/migration/ram-compress.c
@@ -481,14 +481,10 @@ void decompress_data_with_multi_threads(QEMUFile *f, void
*host, int len)
decomp_param[idx].len = len;
qemu_cond_signal(&decomp_param[idx].cond);
qemu_mutex_unlock(&decomp_param[idx].mutex);
- break;
+ return;
}
}
- if (idx < thread_count) {
- break;
- } else {
- qemu_cond_wait(&decomp_done_cond, &decomp_done_lock);
- }
+ qemu_cond_wait(&decomp_done_cond, &decomp_done_lock);
}
}
--
2.41.0
- [PULL 00/11] Migration 20231018 patches, Juan Quintela, 2023/10/18
- [PULL 02/11] migration: Move compression_counters cleanup ram-compress.c, Juan Quintela, 2023/10/18
- [PULL 01/11] migration: RDMA is not compatible with anything else, Juan Quintela, 2023/10/18
- [PULL 04/11] migration: Create ram_compressed_pages(), Juan Quintela, 2023/10/18
- [PULL 07/11] migration: Use "i" as an for index in ram-compress.c, Juan Quintela, 2023/10/18
- [PULL 11/11] migration: save_zero_page() can take block through pss, Juan Quintela, 2023/10/18
- [PULL 09/11] migration: save_compress_page() can take block through pss, Juan Quintela, 2023/10/18
- [PULL 05/11] migration: Move update_compress_threads_counts() to ram-compress.c, Juan Quintela, 2023/10/18
- [PULL 10/11] migration: control_save_page() can take block through pss, Juan Quintela, 2023/10/18
- [PULL 06/11] migration: Simplify decompress_data_with_multi_threads(),
Juan Quintela <=
- [PULL 08/11] migration: Print block status when needed, Juan Quintela, 2023/10/18
- [PULL 03/11] migration: Create populate_compress(), Juan Quintela, 2023/10/18
- Re: [PULL 00/11] Migration 20231018 patches, Stefan Hajnoczi, 2023/10/20