[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/8] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 3/8] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it |
Date: |
Wed, 18 Oct 2023 15:12:15 +0200 |
sysbus_mmio_map() should not be called on unrealized device.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/pcmcia/pxa2xx.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/pcmcia/pxa2xx.c b/hw/pcmcia/pxa2xx.c
index fcca7e571b..e7264feb45 100644
--- a/hw/pcmcia/pxa2xx.c
+++ b/hw/pcmcia/pxa2xx.c
@@ -142,15 +142,12 @@ PXA2xxPCMCIAState *pxa2xx_pcmcia_init(MemoryRegion
*sysmem,
hwaddr base)
{
DeviceState *dev;
- PXA2xxPCMCIAState *s;
dev = qdev_new(TYPE_PXA2XX_PCMCIA);
- sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
- s = PXA2XX_PCMCIA(dev);
-
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
+ sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
- return s;
+ return PXA2XX_PCMCIA(dev);
}
static void pxa2xx_pcmcia_initfn(Object *obj)
--
2.41.0
- [PATCH 0/8] hw/arm/pxa2xx: SysBus/QDev fixes, Philippe Mathieu-Daudé, 2023/10/18
- [PATCH 1/8] hw/sd/pxa2xx: Realize sysbus device before accessing it, Philippe Mathieu-Daudé, 2023/10/18
- [PATCH 2/8] hw/sd/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/18
- [PATCH 3/8] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it,
Philippe Mathieu-Daudé <=
- [PATCH 6/8] hw/intc/pxa2xx: Convert to Resettable interface, Philippe Mathieu-Daudé, 2023/10/18
- [PATCH 4/8] hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/18
- [PATCH 5/8] hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init(), Philippe Mathieu-Daudé, 2023/10/18
- [PATCH 7/8] hw/intc/pxa2xx: Pass CPU reference using QOM link property, Philippe Mathieu-Daudé, 2023/10/18
- [PATCH 8/8] hw/intc/pxa2xx: Factor pxa2xx_pic_realize() out of pxa2xx_pic_init(), Philippe Mathieu-Daudé, 2023/10/18
- Re: [PATCH 0/8] hw/arm/pxa2xx: SysBus/QDev fixes, Philippe Mathieu-Daudé, 2023/10/18