Re: [PATCH V6 0/9] Add architecture agnostic code to support vCPU Hotplug

[Miguel Luis]

> On 16 Oct 2023, at 10:01, Miguel Luis <miguel.luis@oracle.com> wrote:
> 
> Hi Salil,
> 
>> On 16 Oct 2023, at 09:52, Salil Mehta <salil.mehta@huawei.com> wrote:
>> 
>> Hi Miguel,
>> 
>>> From: Miguel Luis <miguel.luis@oracle.com>
>>> Sent: Friday, October 13, 2023 5:34 PM
>>> To: Salil Mehta <salil.mehta@huawei.com>
>>> Cc: qemu-devel@nongnu.org; qemu-arm@nongnu.org; Marc Zyngier
>>> <maz@kernel.org>; jean-philippe@linaro.org; Jonathan Cameron
>>> <jonathan.cameron@huawei.com>; lpieralisi@kernel.org; Peter Maydell
>>> <peter.maydell@linaro.org>; Richard Henderson
>>> <richard.henderson@linaro.org>; imammedo@redhat.com;
>>> andrew.jones@linux.dev; david@redhat.com; philmd@linaro.org;
>>> eric.auger@redhat.com; oliver.upton@linux.dev; pbonzini@redhat.com;
>>> mst@redhat.com; will@kernel.org; gshan@redhat.com; rafael@kernel.org;
>>> alex.bennee@linaro.org; linux@armlinux.org.uk;
>>> darren@os.amperecomputing.com; ilkka@os.amperecomputing.com;
>>> vishnu@os.amperecomputing.com; Karl Heubaum <karl.heubaum@oracle.com>;
>>> salil.mehta@opnsrc.net; zhukeqian <zhukeqian1@huawei.com>; wangxiongfeng
>>> (C) <wangxiongfeng2@huawei.com>; wangyanan (Y) <wangyanan55@huawei.com>;
>>> jiakernel2@gmail.com; maobibo@loongson.cn; lixianglai@loongson.cn; Linuxarm
>>> <linuxarm@huawei.com>
>>> Subject: Re: [PATCH V6 0/9] Add architecture agnostic code to support vCPU
>>> Hotplug
>>> 
>>> Hi Salil,
>>> 
>>>> On 13 Oct 2023, at 10:51, Salil Mehta <salil.mehta@huawei.com> wrote:
>>>> 
>>>> Virtual CPU hotplug support is being added across various
>>> architectures[1][3].
>>>> This series adds various code bits common across all architectures:
>> 
>> 
>> [...]
>> 
>> 
>>> I tested it for Arm64, make check, boot/reboot, live migration and found no
>>> issues,
>>> so for this, please feel free to add:
>>> 
>>> Tested-by: Miguel Luis <miguel.luis@oracle.com>
>> 
>> Great. Many thanks for the confirmation. 
>> 
>> I guess you are repeating the same for x86 as well?
>> 
> 
> You are welcome!
> 
> Absolutely, I’m repeating those same tests for x86.
> 

Unfortunately, there's a qtest failing for x86.

The failing test is device-introspect-test in which the assert for 
mc->possible_cpu_arch_ids fails.

There’s also a suggestion to fix it here: 
15e70616-6abb-63a4-17d0-820f4a254607@opnsrc.net/T/#m108f102b2fe92b7dd7218f2f942f7b233a9d6af3">https://lore.kernel.org/qemu-devel/15e70616-6abb-63a4-17d0-820f4a254607@opnsrc.net/T/#m108f102b2fe92b7dd7218f2f942f7b233a9d6af3

Thanks,
Miguel


> Thanks
> Miguel
> 
>> Salil.