[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 02/12] tests/qtest: Introduce qtest_init_with_env
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH v4 02/12] tests/qtest: Introduce qtest_init_with_env |
Date: |
Thu, 19 Oct 2023 11:16:41 -0300 |
Peter Xu <peterx@redhat.com> writes:
> On Wed, Oct 18, 2023 at 04:27:31PM -0300, Fabiano Rosas wrote:
>> +/**
>> + * qtest_init_with_env:
>> + * @var: Environment variable from where to take the QEMU binary
>> + * @extra_args: Other arguments to pass to QEMU. CAUTION: these
>> + * arguments are subject to word splitting and shell evaluation.
>> + *
>> + * Like qtest_init(), but use a different environment variable for the
>> + * QEMU binary.
>> + *
>> + * Returns: #QTestState instance.
>> + */
>> +QTestState *qtest_init_with_env(const char *var, const char *extra_args);
>
> Another way to do is instead of passing over the env var, passing over
> "char *qemu_bin" always, and take qtest_qemu_binary() as default. Also
> relevant to patch 1. Not a big deal though, so can be done for later.
Here's an low-hanging fruit if someone's interested. =)
I'll take note and do it when I get the chance after the PR merges
otherwise.
Thanks Peter
- [PATCH v4 00/12] tests/migration-test: Allow testing older machine types, Fabiano Rosas, 2023/10/18
- [PATCH v4 01/12] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable, Fabiano Rosas, 2023/10/18
- [PATCH v4 02/12] tests/qtest: Introduce qtest_init_with_env, Fabiano Rosas, 2023/10/18
- [PATCH v4 03/12] tests/qtest: Allow qtest_get_machines to use an alternate QEMU binary, Fabiano Rosas, 2023/10/18
- [PATCH v4 04/12] tests/qtest: Introduce qtest_has_machine_with_env, Fabiano Rosas, 2023/10/18
- [PATCH v4 05/12] tests/qtest: Introduce qtest_resolve_machine_alias, Fabiano Rosas, 2023/10/18
- [PATCH v4 06/12] tests/qtest/migration: Introduce find_common_machine_version, Fabiano Rosas, 2023/10/18
- [PATCH v4 07/12] tests/qtest/migration: Define a machine for all architectures, Fabiano Rosas, 2023/10/18
- [PATCH v4 08/12] tests/qtest/migration: Specify the geometry of the bootsector, Fabiano Rosas, 2023/10/18