[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86 |
|
Date: |
Thu, 19 Oct 2023 14:15:46 -0400 |
On Thu, Oct 19, 2023 at 10:33:08AM +0000, Bernhard Beschow wrote:
>
>
> Am 18. Oktober 2023 17:38:33 UTC schrieb Salil Mehta <salil.mehta@opnsrc.net>:
> >Hello,
>
> Hi Salil,
>
> >Can we assume that every machine type will have all the features which a GED
> >Device can multiplex present together? like will Memory and CPU Hotplug
> >makes sense for all the type of machines?
>
> I can't really answer these questions -- I'm by no means an ACPI expert. My
> idea about removing TYPE_ACPI_GED_X86 really was not more than the commit
> message says: To remove unneeded code.
>
> That said, I wonder myself if the GED device could be uniformly implemented
> across architectures and if -- in theory -- it could be used in the pc-i440fx
> machine instead of the Frankenstein hotplug implementation in PIIX4.
>
> Best regards,
> Bernhard
I am redoing the pull anyway. I dropped this until this discussion
concludes then.
- [PULL v2 23/53] vhost-user: move VhostUserProtocolFeature definition to header file, (continued)
- [PULL v2 23/53] vhost-user: move VhostUserProtocolFeature definition to header file, Michael S. Tsirkin, 2023/10/04
- [PULL v2 22/53] qmp: update virtio feature maps, vhost-user-gpio introspection, Michael S. Tsirkin, 2023/10/04
- [PULL v2 24/53] hw/isa/ich9: Add comment on imperfect emulation of PIC vs. I/O APIC routing, Michael S. Tsirkin, 2023/10/04
- [PULL v2 26/53] hw/acpi/cpu: Have build_cpus_aml() take a build_madt_cpu_fn callback, Michael S. Tsirkin, 2023/10/04
- [PULL v2 28/53] hw/acpi/acpi_dev_interface: Remove now unused #include "hw/boards.h", Michael S. Tsirkin, 2023/10/04
- [PULL v2 25/53] hw/i386/acpi-build: Use pc_madt_cpu_entry() directly, Michael S. Tsirkin, 2023/10/04
- [PULL v2 27/53] hw/acpi/acpi_dev_interface: Remove now unused madt_cpu virtual method, Michael S. Tsirkin, 2023/10/04
- [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86, Michael S. Tsirkin, 2023/10/04
- Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86, Igor Mammedov, 2023/10/27
[PULL v2 31/53] hw/acpi: Trace GPE access in all device models, not just PIIX4, Michael S. Tsirkin, 2023/10/04
[PULL v2 30/53] hw/i386/acpi-build: Determine SMI command port just once, Michael S. Tsirkin, 2023/10/04
[PULL v2 32/53] hw/acpi/core: Trace enable and status registers of GPE separately, Michael S. Tsirkin, 2023/10/04
[PULL v2 34/53] vdpa net: zero vhost_vdpa iova_tree pointer at cleanup, Michael S. Tsirkin, 2023/10/04
[PULL v2 33/53] vdpa: fix gcc cvq_isolated uninitialized variable warning, Michael S. Tsirkin, 2023/10/04
[PULL v2 40/53] vdpa net: fix error message setting virtio status, Michael S. Tsirkin, 2023/10/04
[PULL v2 45/53] pcie_sriov: unregister_vfs(): fix error path, Michael S. Tsirkin, 2023/10/04