[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] hw/m68k/next-cube: Do not open-code sysbus_create_simple
From: |
Thomas Huth |
Subject: |
Re: [PATCH 5/6] hw/m68k/next-cube: Do not open-code sysbus_create_simple() |
Date: |
Sun, 22 Oct 2023 11:42:06 +0200 |
Am Fri, 20 Oct 2023 17:06:25 +0200
schrieb Philippe Mathieu-Daudé <philmd@linaro.org>:
> Mechanical change using the following coccinelle script:
>
> @@
> identifier dev;
> identifier sbd;
> expression qom_type;
> expression addr;
> @@
> - dev = qdev_new(qom_type);
> - sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
> - sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, addr);
> + dev = sysbus_create_simple(qom_type, addr, NULL);
>
> then manually removing the 'dev' variable to avoid:
>
> error: variable 'dev' set but not used [-Werror,-Wunused-but-set-variable]
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
Tested-by: Thomas Huth <huth@tuxfamily.org>
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
- [PATCH 0/6] hw/m68k: Strengthen QOM/SysBus API uses, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 1/6] hw/m68k/irqc: Pass CPU using QOM link property, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 2/6] hw/m68k/mcf5206: Pass CPU using QOM link property, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 3/6] hw/m68k/mcf_intc: Expose MMIO region via SysBus API, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 4/6] hw/m68k/mcf_intc: Pass CPU using QOM link property, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH 5/6] hw/m68k/next-cube: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- Re: [PATCH 5/6] hw/m68k/next-cube: Do not open-code sysbus_create_simple(),
Thomas Huth <=
- [PATCH 6/6] hw/m68k/virt: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- Re: [PATCH 0/6] hw/m68k: Strengthen QOM/SysBus API uses, Richard Henderson, 2023/10/21