qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] include/exec/memop.h: Add MO_TESB


From: Jiajie Chen
Subject: Re: [PATCH 1/5] include/exec/memop.h: Add MO_TESB
Date: Mon, 23 Oct 2023 23:52:09 +0800
User-agent: Mozilla Thunderbird


On 2023/10/23 23:49, David Hildenbrand wrote:

Why?

On 23.10.23 17:29, Jiajie Chen wrote:
Signed-off-by: Jiajie Chen <c@jia.je>
---
  include/exec/memop.h | 1 +
  1 file changed, 1 insertion(+)

diff --git a/include/exec/memop.h b/include/exec/memop.h
index a86dc6743a..834327c62d 100644
--- a/include/exec/memop.h
+++ b/include/exec/memop.h
@@ -140,6 +140,7 @@ typedef enum MemOp {
      MO_TEUL  = MO_TE | MO_UL,
      MO_TEUQ  = MO_TE | MO_UQ,
      MO_TEUO  = MO_TE | MO_UO,
+    MO_TESB  = MO_TE | MO_SB,
      MO_TESW  = MO_TE | MO_SW,
      MO_TESL  = MO_TE | MO_SL,
      MO_TESQ  = MO_TE | MO_SQ,



I recall that the reason for not having this is that the target endianess doesn't matter for single bytes.

Thanks, you are right, I was copying some code using MO_TESW only to find that MO_TESB is missing... I should simply use MO_SB then.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]