[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/12] hw/xen: prevent duplicate device registrations
From: |
David Woodhouse |
Subject: |
Re: [PATCH 09/12] hw/xen: prevent duplicate device registrations |
Date: |
Tue, 24 Oct 2023 15:38:09 +0100 |
User-agent: |
Evolution 3.44.4-0ubuntu2 |
On Tue, 2023-10-24 at 15:10 +0100, Paul Durrant wrote:
> On 16/10/2023 16:19, David Woodhouse wrote:
> > --- a/hw/char/xen_console.c
> > +++ b/hw/char/xen_console.c
> > @@ -468,7 +468,7 @@ static void
> > xen_console_device_create(XenBackendInstance *backend,
> > Chardev *cd = NULL;
> > struct qemu_xs_handle *xsh = xenbus->xsh;
> >
> > - if (qemu_strtoul(name, NULL, 10, &number)) {
> > + if (qemu_strtoul(name, NULL, 10, &number) || number >= INT_MAX) {
> > error_setg(errp, "failed to parse name '%s'", name);
> > goto fail;
> > }
> I don't think this hunk belongs here, does it? Seems like it should be
> in patch 7.
Well, console#4294967295 *did* actually work before this patch started
using -1 to mean something different. But yes, I've already moved that
into the previous patch.
In fact I've just completely dropped this patch now, as the
dedeuplication needs to happen on the *frontend* nodes, since a given
frontend can be powered by a backend of different types, or in
different driver domains.
smime.p7s
Description: S/MIME cryptographic signature
- Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode, (continued)
- Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode, David Woodhouse, 2023/10/24
- Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode, Paul Durrant, 2023/10/24
- Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode, David Woodhouse, 2023/10/24
- Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode, Paul Durrant, 2023/10/25
- Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode, David Woodhouse, 2023/10/25
- Re: [PATCH 12/12] hw/xen: add support for Xen primary console in emulated mode, Paul Durrant, 2023/10/25
[PATCH 08/12] hw/xen: do not repeatedly try to create a failing backend device, David Woodhouse, 2023/10/16
[PATCH 09/12] hw/xen: prevent duplicate device registrations, David Woodhouse, 2023/10/16
[PATCH 03/12] include: update Xen public headers to Xen 4.17.2 release, David Woodhouse, 2023/10/16
Re: [PATCH 0/12] Get Xen PV shim running in qemu, Alex Bennée, 2023/10/24