[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/12] qemu_file: total_transferred is not used anymore
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH 03/12] qemu_file: total_transferred is not used anymore |
Date: |
Tue, 24 Oct 2023 14:35:21 -0300 |
Juan Quintela <quintela@redhat.com> writes:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> migration/qemu-file.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
> index 384985f534..641ab703cc 100644
> --- a/migration/qemu-file.c
> +++ b/migration/qemu-file.c
> @@ -41,9 +41,6 @@ struct QEMUFile {
> QIOChannel *ioc;
> bool is_writable;
>
> - /* The sum of bytes transferred on the wire */
> - uint64_t total_transferred;
> -
> int buf_index;
> int buf_size; /* 0 when writing */
> uint8_t buf[IO_BUF_SIZE];
> @@ -282,7 +279,6 @@ void qemu_fflush(QEMUFile *f)
> qemu_file_set_error_obj(f, -EIO, local_error);
> } else {
> uint64_t size = iov_size(f->iov, f->iovcnt);
> - f->total_transferred += size;
> stat64_add(&mig_stats.qemu_file_transferred, size);
> }
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- [PATCH 09/12] qemu-file: Simplify qemu_file_get_error(), (continued)
- [PATCH 09/12] qemu-file: Simplify qemu_file_get_error(), Juan Quintela, 2023/10/24
- [PATCH 02/12] qemu_file: Use a stat64 for qemu_file_transferred, Juan Quintela, 2023/10/24
- [PATCH 05/12] qemu_file: Remove unused qemu_file_transferred(), Juan Quintela, 2023/10/24
- [PATCH 11/12] migration: Remove transferred atomic counter, Juan Quintela, 2023/10/24
- [PATCH 10/12] migration: Use migration_transferred_bytes(), Juan Quintela, 2023/10/24
- [PATCH 03/12] qemu_file: total_transferred is not used anymore, Juan Quintela, 2023/10/24
- Re: [PATCH 03/12] qemu_file: total_transferred is not used anymore,
Fabiano Rosas <=
- [PATCH 08/12] migration: migration_rate_limit_reset() don't need the QEMUFile, Juan Quintela, 2023/10/24
- [PATCH 12/12] qemu-file: Make qemu_fflush() return errors, Juan Quintela, 2023/10/24
- [PATCH 06/12] qemu-file: Remove _noflush from qemu_file_transferred_noflush(), Juan Quintela, 2023/10/24