[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/11] tests/virtio-scsi: Clean up global variable shadowing
From: |
Thomas Huth |
Subject: |
[PULL 03/11] tests/virtio-scsi: Clean up global variable shadowing |
Date: |
Fri, 27 Oct 2023 11:37:02 +0200 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Rename the (unused) 'allow' argument, following the pattern
used by the other tests in this file. This fixes:
tests/qtest/virtio-scsi-test.c:159:61: error: declaration shadows a variable
in the global scope [-Werror,-Wshadow]
static void hotplug(void *obj, void *data, QGuestAllocator *alloc)
^
tests/qtest/virtio-scsi-test.c:37:25: note: previous declaration is here
static QGuestAllocator *alloc;
^
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-By: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231009100251.56019-4-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/virtio-scsi-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c
index ceaa7f2415..db10d572d0 100644
--- a/tests/qtest/virtio-scsi-test.c
+++ b/tests/qtest/virtio-scsi-test.c
@@ -156,7 +156,7 @@ static QVirtioSCSIQueues *qvirtio_scsi_init(QVirtioDevice
*dev)
return vs;
}
-static void hotplug(void *obj, void *data, QGuestAllocator *alloc)
+static void hotplug(void *obj, void *data, QGuestAllocator *t_alloc)
{
QTestState *qts = global_qtest;
--
2.41.0
- [PULL 00/11] testing patches (+ 1 deprecation patch), Thomas Huth, 2023/10/27
- [PULL 03/11] tests/virtio-scsi: Clean up global variable shadowing,
Thomas Huth <=
- [PULL 02/11] tests/throttle: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 04/11] tests/cdrom-test: Clean up global variable shadowing in prepare_image(), Thomas Huth, 2023/10/27
- [PULL 05/11] tests/rtl8139: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 01/11] system/qtest: Clean up global variable shadowing in qtest_server_init(), Thomas Huth, 2023/10/27
- [PULL 07/11] tests/aio: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 06/11] tests/npcm7xx_adc: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 08/11] tests/coroutine: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 09/11] docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated, Thomas Huth, 2023/10/27
- [PULL 10/11] tests/vm/freebsd: Add additional library paths for libfdt, Thomas Huth, 2023/10/27
- [PULL 11/11] ipmi-bt-test: force ipv4, Thomas Huth, 2023/10/27