[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash
From: |
Sunil V L |
Subject: |
Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash |
Date: |
Mon, 7 Nov 2022 19:38:24 +0530 |
On Mon, Nov 07, 2022 at 01:06:38PM +0000, Peter Maydell wrote:
> On Mon, 7 Nov 2022 at 13:03, Sunil V L <sunilvl@ventanamicro.com> wrote:
> >
> > The pflash implementation currently assumes fixed size of the
> > backend storage. Due to this, the backend storage file needs to be
> > exactly of size 32M. Otherwise, there will be an error like below.
> >
> > "device requires 33554432 bytes, block backend provides 4194304 bytes"
> >
> > Fix this issue by using the actual size of the backing store.
> >
> > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> > ---
>
> Do you really want the flash device size presented to the guest
> to be variable depending on what the user passed as a block backend?
> I don't think this is how we handle flash devices on other boards...
>
Hi Peter,
x86 appears to support variable flash but arm doesn't. What is
the reason for not supporting variable size flash in arm?
Thanks
Sunil
- [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Sunil V L, 2022/11/07
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Peter Maydell, 2022/11/07
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Philippe Mathieu-Daudé, 2022/11/07
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash,
Sunil V L <=
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Alex Bennée, 2022/11/07
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Daniel P . Berrangé, 2022/11/07
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Andrew Jones, 2022/11/07
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Daniel P . Berrangé, 2022/11/07
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Philippe Mathieu-Daudé, 2022/11/08
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Andrew Jones, 2022/11/08
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Daniel P . Berrangé, 2022/11/08
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Markus Armbruster, 2022/11/09
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Daniel P . Berrangé, 2022/11/09
- Re: [PATCH V2] hw/riscv: virt: Remove size restriction for pflash, Markus Armbruster, 2022/11/09