[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci
From: |
Peter Maydell |
Subject: |
Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci |
Date: |
Mon, 21 Nov 2022 14:36:56 +0000 |
On Mon, 21 Nov 2022 at 14:03, Markus Armbruster <armbru@redhat.com> wrote:
>
> Tweak the semantic patch to drop redundant parenthesis around the
> return expression.
>
> Coccinelle drops comments in hw/rdma/vmw/pvrdma_cmd.c; restored
> manually.
>
> Coccinelle messes up vmdk_co_create(), not sure why. Transformed
> manually.
>
> Line breaks in target/avr/cpu.h and hw/rdma/vmw/pvrdma_cmd.c tidied up
> manually.
>
> Whitespace in fuse_reply_iov() tidied up manually.
>
> checkpatch.pl complains "return of an errno should typically be -ve"
> two times for hw/9pfs/9p-synth.c. Preexisting, the patch merely makes
> it visible to checkpatch.pl.
>
> checkpatch.pl complains "return is not a function, parentheses are not
> required" three times for target/mips/tcg/dsp_helper.c. False
> positives.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> .../user/ase/msa/bit-count/test_msa_nloc_b.c | 9 +-
> .../user/ase/msa/bit-count/test_msa_nloc_d.c | 9 +-
[snip long list of other mips test files]
> 328 files changed, 989 insertions(+), 2099 deletions(-)
This patch seems to almost entirely be huge because of these
mips test case files. Are they specific to QEMU or are they
effectively a 3rd-party import that it doesn't make sense
to make local changes to?
I definitely don't think you should put manual tidying changes
in the same patch as 3000 lines of automated changes: that
is in my opinion un-reviewable.
thanks
-- PMM
- [PATCH] cleanup: Tweak and re-run return_directly.cocci, Markus Armbruster, 2022/11/21
- Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci,
Peter Maydell <=
- Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci, Markus Armbruster, 2022/11/21
- Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci, Philippe Mathieu-Daudé, 2022/11/21
- Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci, Markus Armbruster, 2022/11/21
- Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci, Thomas Huth, 2022/11/21
- Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci, Markus Armbruster, 2022/11/22
- Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci, Peter Maydell, 2022/11/22
- Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci, Markus Armbruster, 2022/11/22
- Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci, Peter Maydell, 2022/11/22
- Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci, Philippe Mathieu-Daudé, 2022/11/22
Re: [PATCH] cleanup: Tweak and re-run return_directly.cocci, Max Filippov, 2022/11/21