[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/riscv: Dump sstatus CSR in riscv_cpu_dump_state()
From: |
Alistair Francis |
Subject: |
Re: [PATCH] target/riscv: Dump sstatus CSR in riscv_cpu_dump_state() |
Date: |
Wed, 23 Nov 2022 10:02:28 +1000 |
On Wed, Nov 23, 2022 at 2:07 AM Bin Meng <bmeng@tinylab.org> wrote:
>
> sstatus register dump is currently missing in riscv_cpu_dump_state().
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1332
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
>
> ---
>
> target/riscv/cpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index d14e95c9dc..80d76f0181 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -382,6 +382,7 @@ static void riscv_cpu_dump_state(CPUState *cs, FILE *f,
> int flags)
> CSR_MHARTID,
> CSR_MSTATUS,
> CSR_MSTATUSH,
> + CSR_SSTATUS,
I don't think we need this. mstatus contains all of the information
already and there is limited space to print all of this information
out.
Alistair
> CSR_HSTATUS,
> CSR_VSSTATUS,
> CSR_MIP,
> --
> 2.34.1
>
>