qemu-riscv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 19/21] gdbstub: move register helpers into standalone incl


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 19/21] gdbstub: move register helpers into standalone include
Date: Thu, 5 Jan 2023 18:30:47 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

On 5/1/23 17:43, Alex Bennée wrote:
These inline helpers are all used by target specific code so move them
out of the general header so we don't needlessly pollute the rest of
the API with target specific stuff.

Note we have to include cpu.h in semihosting as it was relying on a
side effect before.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  include/exec/gdbstub.h                 |  86 ---------------------
  include/gdbstub/helpers.h              | 103 +++++++++++++++++++++++++
  semihosting/syscalls.c                 |   1 +
  target/alpha/gdbstub.c                 |   2 +-
  target/arm/gdbstub.c                   |   1 +
  target/arm/gdbstub64.c                 |   2 +-
  target/arm/helper-a64.c                |   2 +-
  target/arm/m_helper.c                  |   2 +-
  target/avr/gdbstub.c                   |   2 +-
  target/cris/gdbstub.c                  |   2 +-
  target/hexagon/gdbstub.c               |   2 +-
  target/hppa/gdbstub.c                  |   2 +-
  target/i386/gdbstub.c                  |   2 +-
  target/i386/whpx/whpx-all.c            |   2 +-
  target/loongarch/gdbstub.c             |   1 +
  target/m68k/gdbstub.c                  |   2 +-
  target/m68k/helper.c                   |   1 +
  target/m68k/m68k-semi.c                |   1 +
  target/microblaze/gdbstub.c            |   2 +-
  target/mips/gdbstub.c                  |   2 +-
  target/mips/tcg/sysemu/mips-semi.c     |   1 +
  target/nios2/cpu.c                     |   2 +-
  target/nios2/nios2-semi.c              |   1 +
  target/openrisc/gdbstub.c              |   2 +-
  target/openrisc/interrupt.c            |   2 +-
  target/openrisc/mmu.c                  |   2 +-
  target/ppc/cpu_init.c                  |   2 +-
  target/ppc/gdbstub.c                   |   1 +
  target/riscv/gdbstub.c                 |   1 +
  target/rx/gdbstub.c                    |   2 +-
  target/s390x/gdbstub.c                 |   1 +
  target/s390x/helper.c                  |   2 +-
  target/sh4/gdbstub.c                   |   2 +-
  target/sparc/gdbstub.c                 |   2 +-
  target/tricore/gdbstub.c               |   2 +-
  target/xtensa/core-dc232b.c            |   2 +-
  target/xtensa/core-dc233c.c            |   2 +-
  target/xtensa/core-de212.c             |   2 +-
  target/xtensa/core-de233_fpu.c         |   2 +-
  target/xtensa/core-dsp3400.c           |   2 +-
  target/xtensa/core-fsf.c               |   2 +-
  target/xtensa/core-lx106.c             |   2 +-
  target/xtensa/core-sample_controller.c |   2 +-
  target/xtensa/core-test_kc705_be.c     |   2 +-
  target/xtensa/core-test_mmuhifi_c3.c   |   2 +-
  target/xtensa/gdbstub.c                |   2 +-
  target/xtensa/helper.c                 |   2 +-
  47 files changed, 148 insertions(+), 121 deletions(-)
  create mode 100644 include/gdbstub/helpers.h

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]