[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/10] hw/riscv/spike.c: simplify create_fdt()
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH 01/10] hw/riscv/spike.c: simplify create_fdt() |
|
Date: |
Mon, 16 Jan 2023 13:53:24 +1000 |
On Thu, Jan 12, 2023 at 3:21 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> 'mem_size' and 'cmdline' are unused.
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/riscv/spike.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c
> index c517885e6e..4a66016d69 100644
> --- a/hw/riscv/spike.c
> +++ b/hw/riscv/spike.c
> @@ -49,7 +49,6 @@ static const MemMapEntry spike_memmap[] = {
> };
>
> static void create_fdt(SpikeState *s, const MemMapEntry *memmap,
> - uint64_t mem_size, const char *cmdline,
> bool is_32_bit, bool htif_custom_base)
> {
> void *fdt;
> @@ -299,8 +298,7 @@ static void spike_board_init(MachineState *machine)
> }
>
> /* Create device tree */
> - create_fdt(s, memmap, machine->ram_size, machine->kernel_cmdline,
> - riscv_is_32bit(&s->soc[0]), htif_custom_base);
> + create_fdt(s, memmap, riscv_is_32bit(&s->soc[0]), htif_custom_base);
>
> /* Load kernel */
> if (machine->kernel_filename) {
> --
> 2.39.0
>
>
- [PATCH 00/10] riscv: create_fdt() related cleanups, Daniel Henrique Barboza, 2023/01/11
- [PATCH 01/10] hw/riscv/spike.c: simplify create_fdt(), Daniel Henrique Barboza, 2023/01/11
- Re: [PATCH 01/10] hw/riscv/spike.c: simplify create_fdt(),
Alistair Francis <=
- [PATCH 02/10] hw/riscv/virt.c: simplify create_fdt(), Daniel Henrique Barboza, 2023/01/11
- [PATCH 03/10] hw/riscv/sifive_u.c: simplify create_fdt(), Daniel Henrique Barboza, 2023/01/11
- [PATCH 04/10] hw/riscv/virt.c: remove 'is_32_bit' param from create_fdt_socket_cpus(), Daniel Henrique Barboza, 2023/01/11
- [PATCH 05/10] hw/riscv: use MachineState::fdt in riscv_socket_fdt_write_id(), Daniel Henrique Barboza, 2023/01/11
- [PATCH 06/10] hw/riscv: use ms->fdt in riscv_socket_fdt_write_distance_matrix(), Daniel Henrique Barboza, 2023/01/11