[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/10] hw/riscv/virt.c: simplify create_fdt()
From: |
Alistair Francis |
Subject: |
Re: [PATCH 02/10] hw/riscv/virt.c: simplify create_fdt() |
Date: |
Mon, 16 Jan 2023 13:54:41 +1000 |
On Thu, Jan 12, 2023 at 3:18 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> 'mem_size' and 'cmdline' aren't being used. Remove them.
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/riscv/virt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index a931ed05ab..89c99ec1af 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -999,7 +999,7 @@ static void create_fdt_fw_cfg(RISCVVirtState *s, const
> MemMapEntry *memmap)
> }
>
> static void create_fdt(RISCVVirtState *s, const MemMapEntry *memmap,
> - uint64_t mem_size, const char *cmdline, bool
> is_32_bit)
> + bool is_32_bit)
> {
> MachineState *mc = MACHINE(s);
> uint32_t phandle = 1, irq_mmio_phandle = 1, msi_pcie_phandle = 1;
> @@ -1499,8 +1499,7 @@ static void virt_machine_init(MachineState *machine)
> virt_flash_map(s, system_memory);
>
> /* create device tree */
> - create_fdt(s, memmap, machine->ram_size, machine->kernel_cmdline,
> - riscv_is_32bit(&s->soc[0]));
> + create_fdt(s, memmap, riscv_is_32bit(&s->soc[0]));
>
> s->machine_done.notify = virt_machine_done;
> qemu_add_machine_init_done_notifier(&s->machine_done);
> --
> 2.39.0
>
>
- [PATCH 00/10] riscv: create_fdt() related cleanups, Daniel Henrique Barboza, 2023/01/11
- [PATCH 01/10] hw/riscv/spike.c: simplify create_fdt(), Daniel Henrique Barboza, 2023/01/11
- [PATCH 02/10] hw/riscv/virt.c: simplify create_fdt(), Daniel Henrique Barboza, 2023/01/11
- Re: [PATCH 02/10] hw/riscv/virt.c: simplify create_fdt(),
Alistair Francis <=
- [PATCH 03/10] hw/riscv/sifive_u.c: simplify create_fdt(), Daniel Henrique Barboza, 2023/01/11
- [PATCH 04/10] hw/riscv/virt.c: remove 'is_32_bit' param from create_fdt_socket_cpus(), Daniel Henrique Barboza, 2023/01/11
- [PATCH 05/10] hw/riscv: use MachineState::fdt in riscv_socket_fdt_write_id(), Daniel Henrique Barboza, 2023/01/11
- [PATCH 06/10] hw/riscv: use ms->fdt in riscv_socket_fdt_write_distance_matrix(), Daniel Henrique Barboza, 2023/01/11
- [PATCH 07/10] hw/riscv: simplify riscv_load_fdt(), Daniel Henrique Barboza, 2023/01/11