Re: [PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h

[Christian Schoenebeck]

On Thursday, January 19, 2023 11:37:00 AM CET Markus Armbruster wrote:
> Christian Schoenebeck <qemu_oss@crudebyte.com> writes:
> 
> > On Thursday, January 19, 2023 7:59:58 AM CET Markus Armbruster wrote:
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >> ---
> >>  hw/9pfs/9p.c | 3 ---
> >>  1 file changed, 3 deletions(-)
> >> 
> >> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> >> index 9621ec1341..aa736af380 100644
> >> --- a/hw/9pfs/9p.c
> >> +++ b/hw/9pfs/9p.c
> >> @@ -17,9 +17,6 @@
> >>   */
> >>  
> >>  #include "qemu/osdep.h"
> >> -#ifdef CONFIG_LINUX
> >> -#include <linux/limits.h>
> >> -#endif
> >>  #include <glib/gprintf.h>
> >>  #include "hw/virtio/virtio.h"
> >>  #include "qapi/error.h"
> >> 
> >
> > Where did that base version come from? I don't see it anywhere in history. 
> > Last relevant change in context was a136d17590a.
> 
> Current master (7ec8aeb6048) has
> 
>     #include "qemu/osdep.h"
>     #ifdef CONFIG_LINUX
>     #include <linux/limits.h>
>     #else
>     #include <limits.h>
>     #endif
>     #include <glib/gprintf.h>
> 
> The previous commit changes it to
> 
>     #include "qemu/osdep.h"
>     #ifdef CONFIG_LINUX
>     #include <linux/limits.h>
>     #endif
>     #include <glib/gprintf.h>
> 
> because "qemu/osdep.h" already includes <limits.h>.
> 
> Clearer now?

Ah, right I missed that in your previous patch. Thanks!

Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

Best regards,
Christian Schoenebeck