RE: [PATCH v4 12/19] target/hexagon: Clean up includes

[Taylor Simpson]

> -----Original Message-----
> From: Markus Armbruster <armbru@redhat.com>
> Sent: Thursday, January 19, 2023 1:00 AM
> To: qemu-devel@nongnu.org
> Cc: richard.henderson@linaro.org; pbonzini@redhat.com;
> kwolf@redhat.com; hreitz@redhat.com; imp@bsdimp.com;
> kevans@freebsd.org; berrange@redhat.com; groug@kaod.org;
> qemu_oss@crudebyte.com; mst@redhat.com; philmd@linaro.org;
> peter.maydell@linaro.org; alistair@alistair23.me; jasowang@redhat.com;
> jonathan.cameron@huawei.com; kbastian@mail.uni-paderborn.de;
> quintela@redhat.com; dgilbert@redhat.com; michael.roth@amd.com;
> kkostiuk@redhat.com; Taylor Simpson <tsimpson@quicinc.com>;
> palmer@dabbelt.com; bin.meng@windriver.com; qemu-block@nongnu.org;
> qemu-arm@nongnu.org; qemu-riscv@nongnu.org
> Subject: [PATCH v4 12/19] target/hexagon: Clean up includes
> 
> Clean up includes so that osdep.h is included first and headers which it
> implies are not included manually.
> 
> This commit was created with scripts/clean-includes.
> 
> Changes to standalone programs dropped, because I can't tell whether them
> not using qemu/osdep.h is intentional:
> 
>     target/hexagon/gen_dectree_import.c
>     target/hexagon/gen_semantics.c
>     target/hexagon/idef-parser/idef-parser.h
>     target/hexagon/idef-parser/parser-helpers.c
>     target/hexagon/idef-parser/parser-helpers.h

Correct.  These are standalone programs not built with the full QEMU context.

> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  target/hexagon/hex_arch_types.h | 1 -
>  target/hexagon/mmvec/macros.h   | 1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>