qemu-riscv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 3/5] riscv: Allow user to set the satp mode


From: Andrew Jones
Subject: Re: [PATCH v6 3/5] riscv: Allow user to set the satp mode
Date: Mon, 23 Jan 2023 11:29:12 +0100

On Mon, Jan 23, 2023 at 10:03:22AM +0100, Alexandre Ghiti wrote:
...
> +/* Sets the satp mode to the max supported */
> +static void set_satp_mode_default(RISCVCPU *cpu, bool is_32_bit)
> +{

nit: When passing in the cpu object pointer there's no need to also pass
is_32_bit, we can just use it from the pointer, cpu->env.misa_mxl == MXL_RV32

Thanks,
drew



reply via email to

[Prev in Thread] Current Thread [Next in Thread]