Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension

From:	Richard Henderson
Subject:	Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension
Date:	Tue, 24 Jan 2023 10:21:52 -1000
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 1/24/23 09:59, Christoph Muellner wrote:

+static bool trans_th_sfence_vmas(DisasContext *ctx, arg_th_sfence_vmas *a)
+{
+    (void) a;
+    REQUIRE_XTHEADSYNC(ctx);
+
+#ifndef CONFIG_USER_ONLY
+    REQUIRE_PRIV_MS(ctx);
+    decode_save_opc(ctx);
+    gen_helper_tlb_flush_all(cpu_env);


Why are you using decode_save_opc() when helper_tlb_flush_all() cannot raise an 
exception?


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 00/14] Add support for the T-Head vendor extensions, Christoph Muellner, 2023/01/24
- [PATCH v3 01/14] RISC-V: Adding XTheadCmo ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension, Christoph Muellner, 2023/01/24
  - Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension, Richard Henderson <=
    - Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension, Christoph Müllner, 2023/01/30
- [PATCH v3 03/14] RISC-V: Adding XTheadBa ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 04/14] RISC-V: Adding XTheadBb ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 05/14] RISC-V: Adding XTheadBs ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 06/14] RISC-V: Adding XTheadCondMov ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 07/14] RISC-V: Adding T-Head multiply-accumulate instructions, Christoph Muellner, 2023/01/24
- [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension, Christoph Muellner, 2023/01/24
  - Re: [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension, Richard Henderson, 2023/01/24
    - Re: [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension, LIU Zhiwei, 2023/01/29
    - Re: [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension, Richard Henderson, 2023/01/30

Prev by Date: [PATCH v3 14/14] target/riscv: add a MAINTAINERS entry for XThead* extension support
Next by Date: Re: [PATCH v4 0/2] riscv: Add support for Zicbo[m,z,p] instructions
Previous by thread: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension
Next by thread: Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension
Index(es):
- Date
- Thread