Re: [PATCH v3 12/14] RISC-V: Add initial support for T-Head C906

qemu-riscv

From:	LIU Zhiwei
Subject:	Re: [PATCH v3 12/14] RISC-V: Add initial support for T-Head C906
Date:	Mon, 30 Jan 2023 17:06:27 +0800
User-agent:	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1


On 2023/1/25 5:26, Richard Henderson wrote:

On 1/24/23 09:59, Christoph Muellner wrote:

+++ b/target/riscv/cpu.h
@@ -27,6 +27,7 @@
  #include "qom/object.h"
  #include "qemu/int128.h"
  #include "cpu_bits.h"
+#include "cpu_vendorid.h"


I don't see that this ID is required for all users of riscv/cpu.h.
This include should be limited to cpu.c.

OK. We can move it to cpu.c

Best Regards,
Zhiwei

r~

Current Thread

[Next in Thread]

Re: [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension, (continued)
- [PATCH v3 10/14] RISC-V: Adding T-Head FMemIdx extension, Christoph Muellner, 2023/01/24
- [PATCH v3 09/14] RISC-V: Adding T-Head MemIdx extension, Christoph Muellner, 2023/01/24
  - Re: [PATCH v3 09/14] RISC-V: Adding T-Head MemIdx extension, Richard Henderson, 2023/01/24
    - Re: [PATCH v3 09/14] RISC-V: Adding T-Head MemIdx extension, LIU Zhiwei, 2023/01/30
    - Re: [PATCH v3 09/14] RISC-V: Adding T-Head MemIdx extension, Christoph Müllner, 2023/01/31
- [PATCH v3 13/14] RISC-V: Adding XTheadFmv ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 11/14] RISC-V: Set minimum priv version for Zfh to 1.11, Christoph Muellner, 2023/01/24
- [PATCH v3 12/14] RISC-V: Add initial support for T-Head C906, Christoph Muellner, 2023/01/24
  - Re: [PATCH v3 12/14] RISC-V: Add initial support for T-Head C906, Richard Henderson, 2023/01/24
    - Re: [PATCH v3 12/14] RISC-V: Add initial support for T-Head C906, LIU Zhiwei <=
    - Re: [PATCH v3 12/14] RISC-V: Add initial support for T-Head C906, Christoph Müllner, 2023/01/31
- [PATCH v3 14/14] target/riscv: add a MAINTAINERS entry for XThead* extension support, Christoph Muellner, 2023/01/24