Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension

From:	Christoph Müllner
Subject:	Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension
Date:	Mon, 30 Jan 2023 15:05:08 +0100

On Tue, Jan 24, 2023 at 9:21 PM Richard Henderson <richard.henderson@linaro.org> wrote:

On 1/24/23 09:59, Christoph Muellner wrote:
> +static bool trans_th_sfence_vmas(DisasContext *ctx, arg_th_sfence_vmas *a)
> +{
> + (void) a;
> + REQUIRE_XTHEADSYNC(ctx);
> +
> +#ifndef CONFIG_USER_ONLY
> + REQUIRE_PRIV_MS(ctx);
> + decode_save_opc(ctx);
> + gen_helper_tlb_flush_all(cpu_env);

Why are you using decode_save_opc() when helper_tlb_flush_all() cannot raise an exception?

No particular reason.

Will be dropped.

Thanks,

Christoph

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 00/14] Add support for the T-Head vendor extensions, Christoph Muellner, 2023/01/24
- [PATCH v3 01/14] RISC-V: Adding XTheadCmo ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension, Christoph Muellner, 2023/01/24
  - Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension, Richard Henderson, 2023/01/24
    - Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension, Christoph Müllner <=
- [PATCH v3 03/14] RISC-V: Adding XTheadBa ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 04/14] RISC-V: Adding XTheadBb ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 05/14] RISC-V: Adding XTheadBs ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 06/14] RISC-V: Adding XTheadCondMov ISA extension, Christoph Muellner, 2023/01/24
- [PATCH v3 07/14] RISC-V: Adding T-Head multiply-accumulate instructions, Christoph Muellner, 2023/01/24
- [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension, Christoph Muellner, 2023/01/24
  - Re: [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension, Richard Henderson, 2023/01/24
    - Re: [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension, LIU Zhiwei, 2023/01/29
    - Re: [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension, Richard Henderson, 2023/01/30
    - Re: [PATCH v3 08/14] RISC-V: Adding T-Head MemPair extension, LIU Zhiwei, 2023/01/30

Prev by Date: Re: [PATCH v2 01/15] RISC-V: Adding XTheadCmo ISA extension
Next by Date: Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message
Previous by thread: Re: [PATCH v3 02/14] RISC-V: Adding XTheadSync ISA extension
Next by thread: [PATCH v3 03/14] RISC-V: Adding XTheadBa ISA extension
Index(es):
- Date
- Thread