[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit messag
From: |
Juan Quintela |
Subject: |
Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message |
Date: |
Mon, 30 Jan 2023 15:12:33 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> wrote:
> The script drops #include "qemu/osdep.h" from headers. Mention it in
> the commit message it uses for --git.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/clean-includes | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/clean-includes b/scripts/clean-includes
> index f0466a6262..f9722c3aec 100755
> --- a/scripts/clean-includes
> +++ b/scripts/clean-includes
> @@ -193,8 +193,8 @@ if [ "$GIT" = "yes" ]; then
> git commit --signoff -F - <<EOF
> $GITSUBJ: Clean up includes
>
> -Clean up includes so that osdep.h is included first and headers
> -which it implies are not included manually.
> +Clean up includes so that qemu/osdep.h is included first in .c, and
> +not in .h, and headers which it implies are not included manually.
I give a tree.
Clean up includes so qemu/osdep.h is never used in .h files. It makes
sure that qemu/osdep.h is only used in .c files. Once there, it assures
that .h files already included in qemu/osdep.h are not included a second
time on the .c file.
What do you think?
And yes, not using "include" the "include files" is ....
interesting/confusing/....
Anyways, if you preffer old text or net one.
Reviewed-by: Juan Quintela <quintela@redhat.com>
- [PATCH v5 00/20] Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 16/20] accel: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 07/20] hw/cxl: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 03/20] scripts/clean-includes: Skip symbolic links, Markus Armbruster, 2023/01/30
- [PATCH v5 09/20] hw/tricore: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message, Markus Armbruster, 2023/01/30
- Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message,
Juan Quintela <=
- [PATCH v5 08/20] hw/input: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 15/20] block: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 06/20] crypto: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 13/20] target/hexagon: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 01/20] scripts/clean-includes: Fully skip / ignore files, Markus Armbruster, 2023/01/30
- [PATCH v5 10/20] qga: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 14/20] riscv: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 19/20] 9p: Drop superfluous include of linux/limits.h, Markus Armbruster, 2023/01/30
- [PATCH v5 12/20] net: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 05/20] bsd-user: Clean up includes, Markus Armbruster, 2023/01/30