[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 08/14] RISC-V: Adding T-Head MemPair extension
|
From: |
Christoph Müllner |
|
Subject: |
Re: [PATCH v4 08/14] RISC-V: Adding T-Head MemPair extension |
|
Date: |
Tue, 31 Jan 2023 21:09:58 +0100 |
On Tue, Jan 31, 2023 at 7:23 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 1/31/23 08:01, Christoph Muellner wrote:
> > + if ((memop & MO_SIZE) == MO_64) {
> > + addr2 = get_address(ctx, a->rs, 8 + (a->sh2 << shamt));
> > + } else {
> > + addr2 = get_address(ctx, a->rs, 4 + (a->sh2 << shamt));
> > + }
>
> Use memop_size(memop) instead.
Will be part of v5 (will be sent in a couple of minutes).
I have also added a "int imm = a->sh2 << shamt;".
>
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Thanks for the review!
>
>
> r~
- [PATCH v4 05/14] RISC-V: Adding XTheadBs ISA extension, (continued)
- [PATCH v4 05/14] RISC-V: Adding XTheadBs ISA extension, Christoph Muellner, 2023/01/31
- [PATCH v4 02/14] RISC-V: Adding XTheadSync ISA extension, Christoph Muellner, 2023/01/31
- [PATCH v4 14/14] target/riscv: add a MAINTAINERS entry for XThead* extension support, Christoph Muellner, 2023/01/31
- [PATCH v4 01/14] RISC-V: Adding XTheadCmo ISA extension, Christoph Muellner, 2023/01/31
- [PATCH v4 09/14] RISC-V: Adding T-Head MemIdx extension, Christoph Muellner, 2023/01/31
- [PATCH v4 13/14] RISC-V: Adding XTheadFmv ISA extension, Christoph Muellner, 2023/01/31
- [PATCH v4 12/14] RISC-V: Add initial support for T-Head C906, Christoph Muellner, 2023/01/31
- [PATCH v4 10/14] RISC-V: Adding T-Head FMemIdx extension, Christoph Muellner, 2023/01/31
- [PATCH v4 08/14] RISC-V: Adding T-Head MemPair extension, Christoph Muellner, 2023/01/31
- [PATCH v4 11/14] RISC-V: Set minimum priv version for Zfh to 1.11, Christoph Muellner, 2023/01/31