[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 14/20] target/riscv/kvm.c: add multi-letter extension KVM
|
From: |
Andrew Jones |
|
Subject: |
Re: [PATCH v8 14/20] target/riscv/kvm.c: add multi-letter extension KVM properties |
|
Date: |
Thu, 6 Jul 2023 11:37:48 +0200 |
On Thu, Jul 06, 2023 at 10:45:04AM +0200, Andrew Jones wrote:
...
> 1. Audit KVM to ensure using EINVAL for get-one-reg's "register not
> present" is currently safe, and keep our eye on KVM to make sure
> it remains safe until get-reg-list lands.
I just did the audit and it looks fine. There's only one way these types
of get-one-reg invocations can return EINVAL other than for "register
not present" and that's for the encoded reg size not being
sizeof(unsigned long). As long as we construct the register ID with the
correct size then that can't happen. We currently construct it with
kvm_riscv_reg_id() which does the right thing for these invocations.
Thanks,
drew
- [PATCH v8 06/20] target/riscv: use KVM scratch CPUs to init KVM properties, (continued)
- [PATCH v8 06/20] target/riscv: use KVM scratch CPUs to init KVM properties, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 07/20] target/riscv: read marchid/mimpid in kvm_riscv_init_machine_ids(), Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 08/20] target/riscv: handle mvendorid/marchid/mimpid for KVM CPUs, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 09/20] linux-headers: Update to v6.4-rc1, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 10/20] target/riscv/kvm.c: init 'misa_ext_mask' with scratch CPU, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 11/20] target/riscv/cpu: add misa_ext_info_arr[], Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 12/20] target/riscv: add KVM specific MISA properties, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 13/20] target/riscv/kvm.c: update KVM MISA bits, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 14/20] target/riscv/kvm.c: add multi-letter extension KVM properties, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 15/20] target/riscv/cpu.c: add satp_mode properties earlier, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 16/20] target/riscv/cpu.c: remove priv_ver check from riscv_isa_string_ext(), Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 17/20] target/riscv/cpu.c: create KVM mock properties, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 18/20] target/riscv: update multi-letter extension KVM properties, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 19/20] target/riscv/kvm.c: add kvmconfig_get_cfg_addr() helper, Daniel Henrique Barboza, 2023/07/05
- [PATCH v8 20/20] target/riscv/kvm.c: read/write (cbom|cboz)_blocksize in KVM, Daniel Henrique Barboza, 2023/07/05