Re: [PATCH for-8.2 v3 0/8] target/riscv: add 'max' CPU, deprecate

[Daniel Henrique Barboza]

Alistair,

I'm doing some overly complicated stuff here w.r.t to KVM specific code
that are biting me back in further cleanups I'm working on.

I'll do some changes in this series and re-send. Thanks,


Daniel

On 7/14/23 14:43, Daniel Henrique Barboza wrote:
> Hi,
>
> This version has changes suggested in v2. The most significant change is
> the deprecation of the 'any' CPU in patch 8.
>
> The reasoning behind it is that Alistair mentioned that the 'any' CPU
> intended to work like the newly added 'max' CPU, so we're better of
> removing the 'any' CPU since it'll be out of place. We can't just
> remove the CPU out of the gate so we'll have to make it do with
> deprecation first.
>
> Patches missing review: 5,6,7,8
>
> Changes from v2:
> - patches 1, 3, 4:
>    - remove "DEFINE_PROP_END_OF_LIST()" at the end of each prop array;
>    - use ARRAY_SIZE() in the for loop
> - patch 5:
>    - remove the trailing '/' in the last line of the macro
>    - wrap the macro in "do {} while (0)"
> - patch 8 (new):
>    - deprecate the 'any' CPU
> - v2 link: 
> 20230712205748.446931-1-dbarboza@ventanamicro.com/">https://lore.kernel.org/qemu-riscv/20230712205748.446931-1-dbarboza@ventanamicro.com/
>
> Daniel Henrique Barboza (8):
>    target/riscv/cpu.c: split CPU options from riscv_cpu_extensions[]
>    target/riscv/cpu.c: skip 'bool' check when filtering KVM props
>    target/riscv/cpu.c: split vendor exts from riscv_cpu_extensions[]
>    target/riscv/cpu.c: split non-ratified exts from
>      riscv_cpu_extensions[]
>    target/riscv/cpu.c: add a ADD_CPU_PROPERTIES_ARRAY() macro
>    target/riscv: add 'max' CPU type
>    avocado, risc-v: add opensbi tests for 'max' CPU
>    target/riscv: deprecate the 'any' CPU type
>
>   docs/about/deprecated.rst      |  12 ++++
>   target/riscv/cpu-qom.h         |   1 +
>   target/riscv/cpu.c             | 114 ++++++++++++++++++++++++++-------
>   tests/avocado/riscv_opensbi.py |  16 +++++
>   4 files changed, 121 insertions(+), 22 deletions(-)