qemu-riscv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/riscv: Fix page_check_range use in fault-only-first


From: LIU Zhiwei
Subject: Re: [PATCH] target/riscv: Fix page_check_range use in fault-only-first
Date: Tue, 1 Aug 2023 11:37:27 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0


On 2023/7/30 5:18, Richard Henderson wrote:
On 7/28/23 20:16, LIU Zhiwei wrote:
Commit bef6f008b98(accel/tcg: Return bool from page_check_range) converts
integer return value to bool type. However, it wrongly converted the use
of the API in riscv fault-only-first, where page_check_range < = 0, should
be converted to !page_check_range.

Signed-off-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
---
  target/riscv/vector_helper.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

As far as it goes,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

though the test will never fail, because tlb_vaddr_to_host just succeeded.

It fails one test case in linux-user mode, where tlb_vaddr_to_host always succeeded.

Zhiwei



r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]