[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 07/20] target/riscv/cpu.c: add riscv_cpu_add_qdev_prop_arr
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH v9 07/20] target/riscv/cpu.c: add riscv_cpu_add_qdev_prop_array() |
|
Date: |
Mon, 4 Sep 2023 11:51:17 +1000 |
On Sat, Sep 2, 2023 at 5:49 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> The code inside riscv_cpu_add_user_properties() became quite repetitive
> after recent changes. Add a helper to hide the repetition away.
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/cpu.c | 29 +++++++++++++----------------
> 1 file changed, 13 insertions(+), 16 deletions(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 86d536f242..d484d63bcd 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -1951,6 +1951,15 @@ static void cpu_set_cfg_unavailable(Object *obj,
> Visitor *v,
> }
> #endif
>
> +static void riscv_cpu_add_qdev_prop_array(DeviceState *dev, Property *array)
> +{
> + g_assert(array);
> +
> + for (Property *prop = array; prop && prop->name; prop++) {
> + qdev_property_add_static(dev, prop);
> + }
> +}
> +
> #ifndef CONFIG_USER_ONLY
> static void riscv_cpu_add_kvm_unavail_prop(Object *obj, const char
> *prop_name)
> {
> @@ -2007,7 +2016,6 @@ static void riscv_cpu_add_kvm_properties(Object *obj)
> */
> static void riscv_cpu_add_user_properties(Object *obj)
> {
> - Property *prop;
> DeviceState *dev = DEVICE(obj);
>
> #ifndef CONFIG_USER_ONLY
> @@ -2021,21 +2029,10 @@ static void riscv_cpu_add_user_properties(Object *obj)
>
> riscv_cpu_add_misa_properties(obj);
>
> - for (prop = riscv_cpu_extensions; prop && prop->name; prop++) {
> - qdev_property_add_static(dev, prop);
> - }
> -
> - for (prop = riscv_cpu_options; prop && prop->name; prop++) {
> - qdev_property_add_static(dev, prop);
> - }
> -
> - for (prop = riscv_cpu_vendor_exts; prop && prop->name; prop++) {
> - qdev_property_add_static(dev, prop);
> - }
> -
> - for (prop = riscv_cpu_experimental_exts; prop && prop->name; prop++) {
> - qdev_property_add_static(dev, prop);
> - }
> + riscv_cpu_add_qdev_prop_array(dev, riscv_cpu_extensions);
> + riscv_cpu_add_qdev_prop_array(dev, riscv_cpu_options);
> + riscv_cpu_add_qdev_prop_array(dev, riscv_cpu_vendor_exts);
> + riscv_cpu_add_qdev_prop_array(dev, riscv_cpu_experimental_exts);
> }
>
> static Property riscv_cpu_properties[] = {
> --
> 2.41.0
>
>
- Re: [PATCH v9 03/20] target/riscv/cpu.c: split kvm prop handling to its own helper, (continued)
- [PATCH v9 04/20] target/riscv: add DEFINE_PROP_END_OF_LIST() to riscv_cpu_options[], Daniel Henrique Barboza, 2023/09/01
- [PATCH v9 05/20] target/riscv/cpu.c: split non-ratified exts from riscv_cpu_extensions[], Daniel Henrique Barboza, 2023/09/01
- [PATCH v9 06/20] target/riscv/cpu.c: split vendor exts from riscv_cpu_extensions[], Daniel Henrique Barboza, 2023/09/01
- [PATCH v9 08/20] target/riscv/cpu.c: add riscv_cpu_add_kvm_unavail_prop_array(), Daniel Henrique Barboza, 2023/09/01
- [PATCH v9 09/20] target/riscv/cpu.c: limit cfg->vext_spec log message, Daniel Henrique Barboza, 2023/09/01
- [PATCH v9 07/20] target/riscv/cpu.c: add riscv_cpu_add_qdev_prop_array(), Daniel Henrique Barboza, 2023/09/01
- [PATCH v9 10/20] target/riscv: add 'max' CPU type, Daniel Henrique Barboza, 2023/09/01
- [PATCH v9 11/20] avocado, risc-v: add tuxboot tests for 'max' CPU, Daniel Henrique Barboza, 2023/09/01
- [PATCH v9 12/20] target/riscv: deprecate the 'any' CPU type, Daniel Henrique Barboza, 2023/09/01
- [PATCH v9 13/20] target/riscv/cpu.c: use offset in isa_ext_is_enabled/update_enabled, Daniel Henrique Barboza, 2023/09/01
- [PATCH v9 15/20] target/riscv/cpu.c: introduce cpu_cfg_ext_auto_update(), Daniel Henrique Barboza, 2023/09/01