Re: [PATCH 1/4] hw/riscv: opentitan: Fixup local variables shadowing

[Daniel Henrique Barboza]

On 9/25/23 01:30, Alistair Francis wrote:
> Local variables shadowing other local variables or parameters make the
> code needlessly hard to understand.  Bugs love to hide in such code.
> Evidence: "[PATCH v3 1/7] migration/rdma: Fix save_page method to fail
> on polling error".
>
> This patch removes the local variable shadowing. Tested by adding:
>
>      --extra-cflags='-Wshadow=local -Wno-error=shadow=local 
> -Wno-error=shadow=compatible-local'
>
> To configure
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---

Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

>   hw/riscv/opentitan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c
> index 6a2fcc4ade..436503f1ba 100644
> --- a/hw/riscv/opentitan.c
> +++ b/hw/riscv/opentitan.c
> @@ -227,7 +227,7 @@ static void lowrisc_ibex_soc_realize(DeviceState *dev_soc, 
> Error **errp)
>                                              IRQ_M_TIMER));
>   
>       /* SPI-Hosts */
> -    for (int i = 0; i < OPENTITAN_NUM_SPI_HOSTS; ++i) {
> +    for (i = 0; i < OPENTITAN_NUM_SPI_HOSTS; ++i) {
>           dev = DEVICE(&(s->spi_host[i]));
>           if (!sysbus_realize(SYS_BUS_DEVICE(&s->spi_host[i]), errp)) {
>               return;