[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] target/riscv: rename ext_i* to ext_zi*
From: |
Andrew Jones |
Subject: |
Re: [PATCH 0/4] target/riscv: rename ext_i* to ext_zi* |
Date: |
Fri, 13 Oct 2023 08:37:30 +0200 |
On Thu, Oct 12, 2023 at 01:46:00PM -0300, Daniel Henrique Barboza wrote:
> Hi,
>
> This series renames the following internal extensions flags:
>
> ext_ifencei, ext_icsr, ext_icbom, ext_icboz
>
> To add a leading 'z':
>
> ext_zifencei, ext_zicsr, ext_zicbom, ext_zicboz
>
> This was proposed by Andrew Jones. The motivation, in his own words:
>
> "I'd prefer we name the booleans with their 'z' to improve grepping.
> When one wants to search for uses of zifencei, I imagine they're more
> likely to do 'grep -i zifencei' than 'grep -i ifencei', particularly
> because the 's' is maintained for S extensions. "
>
>
> Aside from that, these are the only 4 Z-extension flags that don't use a
> leading 'z' in their name, so there's also the benefit of making
> everything equal.
>
For the series,
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Thanks,
drew
- [PATCH 0/4] target/riscv: rename ext_i* to ext_zi*, Daniel Henrique Barboza, 2023/10/12
- [PATCH 1/4] target/riscv: rename ext_ifencei to ext_zifencei, Daniel Henrique Barboza, 2023/10/12
- [PATCH 2/4] target/riscv: rename ext_icsr to ext_zicsr, Daniel Henrique Barboza, 2023/10/12
- [PATCH 3/4] target/riscv: rename ext_icbom to ext_zicbom, Daniel Henrique Barboza, 2023/10/12
- [PATCH 4/4] target/riscv: rename ext_icboz to ext_zicboz, Daniel Henrique Barboza, 2023/10/12
- Re: [PATCH 0/4] target/riscv: rename ext_i* to ext_zi*,
Andrew Jones <=
- Re: [PATCH 0/4] target/riscv: rename ext_i* to ext_zi*, Alistair Francis, 2023/10/16