[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 9/9] target/riscv/tcg: warn if profile exts are disabled
|
From: |
Andrew Jones |
|
Subject: |
Re: [PATCH v4 9/9] target/riscv/tcg: warn if profile exts are disabled |
|
Date: |
Wed, 25 Oct 2023 18:28:03 +0200 |
On Wed, Oct 25, 2023 at 10:50:01AM -0300, Daniel Henrique Barboza wrote:
> Enabling a profile and then disabling some of its mandatory extensions
> is a valid use. It can be useful for debugging and testing. But the
> common expected use of enabling a profile is to enable all its mandatory
> extensions.
>
> Add an user warning when mandatory extensions from an enabled profile
> are disabled in the command line, like we're already doing with RVG.
>
> After this patch, this will throw warnings:
>
> -cpu rv64,rva22u64=true,zihintpause=false,zicbom=false,zicboz=false
>
> qemu-system-riscv64: warning: Profile rva22u64 mandates disabled extension
> zihintpause
> qemu-system-riscv64: warning: Profile rva22u64 mandates disabled extension
> zicbom
> qemu-system-riscv64: warning: Profile rva22u64 mandates disabled extension
> zicboz
>
> Note that the following will NOT throw warnings because the profile is
> being enabled last, hence all its mandatory extensions will be enabled:
>
> -cpu rv64,zihintpause=false,zicbom=false,zicboz=false,rva22u64=true
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
> target/riscv/tcg/tcg-cpu.c | 57 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
- Re: [PATCH v4 1/9] target/riscv: add rva22u64 profile definition, (continued)
- [PATCH v4 3/9] target/riscv/tcg: add user flag for profile support, Daniel Henrique Barboza, 2023/10/25
- [PATCH v4 2/9] target/riscv/kvm: add 'rva22u64' flag as unavailable, Daniel Henrique Barboza, 2023/10/25
- [PATCH v4 4/9] target/riscv/tcg: add MISA user options hash, Daniel Henrique Barboza, 2023/10/25
- [PATCH v4 8/9] target/riscv/tcg: honor user choice for G MISA bits, Daniel Henrique Barboza, 2023/10/25
- [PATCH v4 9/9] target/riscv/tcg: warn if profile exts are disabled, Daniel Henrique Barboza, 2023/10/25
- Re: [PATCH v4 9/9] target/riscv/tcg: warn if profile exts are disabled,
Andrew Jones <=
- [PATCH v4 5/9] target/riscv/tcg: add riscv_cpu_write_misa_bit(), Daniel Henrique Barboza, 2023/10/25
- [PATCH v4 7/9] target/riscv/tcg: add hash table insert helpers, Daniel Henrique Barboza, 2023/10/25
- [PATCH v4 6/9] target/riscv/tcg: handle profile MISA bits, Daniel Henrique Barboza, 2023/10/25