[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 10/19] target/riscv/tcg: add user flag for profile support
|
From: |
Andrew Jones |
|
Subject: |
Re: [PATCH v9 10/19] target/riscv/tcg: add user flag for profile support |
|
Date: |
Fri, 3 Nov 2023 09:41:39 +0100 |
On Thu, Nov 02, 2023 at 07:44:36PM -0300, Daniel Henrique Barboza wrote:
...
> + if (profile->enabled) {
> + /*
> + * Note: the 'priv_spec' command line option, if present,
> + * will take precedence over this priv_ver bump.
> + */
> + cpu_validate_multi_ext_priv_ver(&cpu->env, ext_offset);
> + }
If we moved the comment into cpu_validate_multi_ext_priv_ver() we wouldn't
need it's third occurrence to be added here.
Thanks,
drew
- [PATCH v9 04/19] target/riscv: add rv64i CPU, (continued)
- [PATCH v9 04/19] target/riscv: add rv64i CPU, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 06/19] target/riscv/tcg: add 'zic64b' support, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 07/19] riscv-qmp-cmds.c: expose named features in cpu_model_expansion, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 08/19] target/riscv: add rva22u64 profile definition, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 09/19] target/riscv/kvm: add 'rva22u64' flag as unavailable, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 11/19] target/riscv/tcg: add MISA user options hash, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 14/19] target/riscv/tcg: add hash table insert helpers, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 12/19] target/riscv/tcg: add riscv_cpu_write_misa_bit(), Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 10/19] target/riscv/tcg: add user flag for profile support, Daniel Henrique Barboza, 2023/11/02
- Re: [PATCH v9 10/19] target/riscv/tcg: add user flag for profile support,
Andrew Jones <=
- [PATCH v9 18/19] target/riscv: add 'rva22u64' CPU, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 05/19] target/riscv: add zicbop extension flag, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 17/19] riscv-qmp-cmds.c: add profile flags in cpu-model-expansion, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 19/19] target/riscv/tcg: do not support profiles for 'max' CPU, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 13/19] target/riscv/tcg: handle profile MISA bits, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 16/19] target/riscv/tcg: validate profiles during finalize, Daniel Henrique Barboza, 2023/11/02
- [PATCH v9 15/19] target/riscv/tcg: honor user choice for G MISA bits, Daniel Henrique Barboza, 2023/11/02