Re: [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element_loa

From:	Richard Henderson
Subject:	Re: [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element_loadx()
Date:	Tue, 16 Jan 2024 07:16:52 +1100
User-agent:	Mozilla Thunderbird

On 1/16/24 04:57, Daniel Henrique Barboza wrote:

I am now wondering if this is worth the trouble, and we should instead do:

+    int vlmax = cpu->cfg.vlenb >> (s->sew - s->lmul);

Like we're already doing in patch 9. Patch 12 would be a similar case.


This is more like what I expected to see.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 05/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb', (continued)
- [PATCH 05/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb', Daniel Henrique Barboza, 2024/01/12
- [PATCH 06/13] target/riscv/insn_trans/trans_rvvk.c.inc: use 'vlenb', Daniel Henrique Barboza, 2024/01/12
- [PATCH 07/13] target/riscv/vector_helper.c: use 'vlenb', Daniel Henrique Barboza, 2024/01/12
- [PATCH 08/13] target/riscv/vector_helper.c: use vlenb in HELPER(vsetvl), Daniel Henrique Barboza, 2024/01/12
  - Re: [PATCH 08/13] target/riscv/vector_helper.c: use vlenb in HELPER(vsetvl), Richard Henderson, 2024/01/12
- [PATCH 09/13] target/riscv/cpu.h: use 'vlenb' in vext_get_vlmax(), Daniel Henrique Barboza, 2024/01/12
  - Re: [PATCH 09/13] target/riscv/cpu.h: use 'vlenb' in vext_get_vlmax(), Richard Henderson, 2024/01/12
- [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element_loadx(), Daniel Henrique Barboza, 2024/01/12
  - Re: [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element_loadx(), Richard Henderson, 2024/01/12
    - Re: [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element_loadx(), Daniel Henrique Barboza, 2024/01/15
    - Re: [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element_loadx(), Richard Henderson <=
- [PATCH 10/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb' in MAXSZ(), Daniel Henrique Barboza, 2024/01/12
  - Re: [PATCH 10/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb' in MAXSZ(), Richard Henderson, 2024/01/12
    - Re: [PATCH 10/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb' in MAXSZ(), Daniel Henrique Barboza, 2024/01/15
- [PATCH 12/13] trans_rvv.c.inc: use cpu_vl in trans_vrgather_vi(), Daniel Henrique Barboza, 2024/01/12
- [PATCH 13/13] target/riscv/cpu.c: remove cpu->cfg.vlen, Daniel Henrique Barboza, 2024/01/12

Prev by Date: Re: [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element_loadx()
Next by Date: [PATCH v2 00/12] target/riscv: add 'cpu->cfg.vlenb', remove 'cpu->cfg.vlen'
Previous by thread: Re: [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element_loadx()
Next by thread: [PATCH 10/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb' in MAXSZ()
Index(es):
- Date
- Thread