[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/13] target/riscv/csr.c: use 'vlenb' instead of 'vlen'
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH v3 02/13] target/riscv/csr.c: use 'vlenb' instead of 'vlen' |
|
Date: |
Mon, 22 Jan 2024 12:55:22 +1000 |
On Wed, Jan 17, 2024 at 7:00 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> As a bonus, we're being more idiomatic using cpu->cfg.vlenb when
> reading CSR_VLENB.
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/csr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/riscv/csr.c b/target/riscv/csr.c
> index 674ea075a4..5c8d22452b 100644
> --- a/target/riscv/csr.c
> +++ b/target/riscv/csr.c
> @@ -683,7 +683,7 @@ static RISCVException read_vl(CPURISCVState *env, int
> csrno,
>
> static int read_vlenb(CPURISCVState *env, int csrno, target_ulong *val)
> {
> - *val = riscv_cpu_cfg(env)->vlen >> 3;
> + *val = riscv_cpu_cfg(env)->vlenb;
> return RISCV_EXCP_NONE;
> }
>
> @@ -738,7 +738,7 @@ static RISCVException write_vstart(CPURISCVState *env,
> int csrno,
> * The vstart CSR is defined to have only enough writable bits
> * to hold the largest element index, i.e. lg2(VLEN) bits.
> */
> - env->vstart = val & ~(~0ULL << ctzl(riscv_cpu_cfg(env)->vlen));
> + env->vstart = val & ~(~0ULL << ctzl(riscv_cpu_cfg(env)->vlenb << 3));
> return RISCV_EXCP_NONE;
> }
>
> --
> 2.43.0
>
>
- [PATCH v3 00/13] target/riscv: add 'cpu->cfg.vlenb', remove 'cpu->cfg.vlen', Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 01/13] target/riscv: add 'vlenb' field in cpu->cfg, Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 02/13] target/riscv/csr.c: use 'vlenb' instead of 'vlen', Daniel Henrique Barboza, 2024/01/16
- Re: [PATCH v3 02/13] target/riscv/csr.c: use 'vlenb' instead of 'vlen',
Alistair Francis <=
- [PATCH v3 03/13] target/riscv/gdbstub.c: use 'vlenb' instead of shifting 'vlen', Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 04/13] target/riscv/insn_trans/trans_rvbf16.c.inc: use cpu->cfg.vlenb, Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 05/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb', Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 06/13] target/riscv/insn_trans/trans_rvvk.c.inc: use 'vlenb', Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 07/13] target/riscv/vector_helper.c: use 'vlenb', Daniel Henrique Barboza, 2024/01/16