[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 07/13] target/riscv/vector_helper.c: use 'vlenb'
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH v3 07/13] target/riscv/vector_helper.c: use 'vlenb' |
|
Date: |
Mon, 22 Jan 2024 12:59:47 +1000 |
On Wed, Jan 17, 2024 at 8:18 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> Use 'cpu->cfg.vlenb' instead of 'cpu->cfg.vlen >> 3'.
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/vector_helper.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
> index c1c3a4d1ea..cb944229b0 100644
> --- a/target/riscv/vector_helper.c
> +++ b/target/riscv/vector_helper.c
> @@ -558,7 +558,7 @@ vext_ldst_whole(void *vd, target_ulong base,
> CPURISCVState *env, uint32_t desc,
> {
> uint32_t i, k, off, pos;
> uint32_t nf = vext_nf(desc);
> - uint32_t vlenb = riscv_cpu_cfg(env)->vlen >> 3;
> + uint32_t vlenb = riscv_cpu_cfg(env)->vlenb;
> uint32_t max_elems = vlenb >> log2_esz;
>
> k = env->vstart / max_elems;
> @@ -929,7 +929,7 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1, void
> *vs2, \
> { \
> uint32_t vl = env->vl; \
> uint32_t vm = vext_vm(desc); \
> - uint32_t total_elems = riscv_cpu_cfg(env)->vlen; \
> + uint32_t total_elems = riscv_cpu_cfg(env)->vlenb << 3; \
> uint32_t vta_all_1s = vext_vta_all_1s(desc); \
> uint32_t i; \
> \
> @@ -967,7 +967,7 @@ void HELPER(NAME)(void *vd, void *v0, target_ulong s1,
> \
> { \
> uint32_t vl = env->vl; \
> uint32_t vm = vext_vm(desc); \
> - uint32_t total_elems = riscv_cpu_cfg(env)->vlen; \
> + uint32_t total_elems = riscv_cpu_cfg(env)->vlenb << 3; \
> uint32_t vta_all_1s = vext_vta_all_1s(desc); \
> uint32_t i; \
> \
> @@ -1171,7 +1171,7 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1, void
> *vs2, \
> { \
> uint32_t vm = vext_vm(desc); \
> uint32_t vl = env->vl; \
> - uint32_t total_elems = riscv_cpu_cfg(env)->vlen; \
> + uint32_t total_elems = riscv_cpu_cfg(env)->vlenb << 3; \
> uint32_t vta_all_1s = vext_vta_all_1s(desc); \
> uint32_t vma = vext_vma(desc); \
> uint32_t i; \
> @@ -1236,7 +1236,7 @@ void HELPER(NAME)(void *vd, void *v0, target_ulong s1,
> void *vs2, \
> { \
> uint32_t vm = vext_vm(desc); \
> uint32_t vl = env->vl; \
> - uint32_t total_elems = riscv_cpu_cfg(env)->vlen; \
> + uint32_t total_elems = riscv_cpu_cfg(env)->vlenb << 3; \
> uint32_t vta_all_1s = vext_vta_all_1s(desc); \
> uint32_t vma = vext_vma(desc); \
> uint32_t i; \
> @@ -3971,7 +3971,7 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1, void
> *vs2, \
> { \
> uint32_t vm = vext_vm(desc); \
> uint32_t vl = env->vl; \
> - uint32_t total_elems = riscv_cpu_cfg(env)->vlen; \
> + uint32_t total_elems = riscv_cpu_cfg(env)->vlenb << 3; \
> uint32_t vta_all_1s = vext_vta_all_1s(desc); \
> uint32_t vma = vext_vma(desc); \
> uint32_t i; \
> @@ -4011,7 +4011,7 @@ void HELPER(NAME)(void *vd, void *v0, uint64_t s1, void
> *vs2, \
> { \
> uint32_t vm = vext_vm(desc); \
> uint32_t vl = env->vl; \
> - uint32_t total_elems = riscv_cpu_cfg(env)->vlen; \
> + uint32_t total_elems = riscv_cpu_cfg(env)->vlenb << 3; \
> uint32_t vta_all_1s = vext_vta_all_1s(desc); \
> uint32_t vma = vext_vma(desc); \
> uint32_t i; \
> @@ -4528,7 +4528,7 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1,
> \
> uint32_t desc) \
> { \
> uint32_t vl = env->vl; \
> - uint32_t total_elems = riscv_cpu_cfg(env)->vlen; \
> + uint32_t total_elems = riscv_cpu_cfg(env)->vlenb << 3;\
> uint32_t vta_all_1s = vext_vta_all_1s(desc); \
> uint32_t i; \
> int a, b; \
> @@ -4615,7 +4615,7 @@ static void vmsetm(void *vd, void *v0, void *vs2,
> CPURISCVState *env,
> {
> uint32_t vm = vext_vm(desc);
> uint32_t vl = env->vl;
> - uint32_t total_elems = riscv_cpu_cfg(env)->vlen;
> + uint32_t total_elems = riscv_cpu_cfg(env)->vlenb << 3;
> uint32_t vta_all_1s = vext_vta_all_1s(desc);
> uint32_t vma = vext_vma(desc);
> int i;
> --
> 2.43.0
>
>
- Re: [PATCH v3 02/13] target/riscv/csr.c: use 'vlenb' instead of 'vlen', (continued)
- [PATCH v3 03/13] target/riscv/gdbstub.c: use 'vlenb' instead of shifting 'vlen', Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 04/13] target/riscv/insn_trans/trans_rvbf16.c.inc: use cpu->cfg.vlenb, Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 05/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb', Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 06/13] target/riscv/insn_trans/trans_rvvk.c.inc: use 'vlenb', Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 07/13] target/riscv/vector_helper.c: use 'vlenb', Daniel Henrique Barboza, 2024/01/16
- Re: [PATCH v3 07/13] target/riscv/vector_helper.c: use 'vlenb',
Alistair Francis <=
- [PATCH v3 08/13] target/riscv/vector_helper.c: use vlenb in HELPER(vsetvl), Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 09/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb' in MAXSZ(), Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 10/13] target/riscv/cpu.h: use 'vlenb' in vext_get_vlmax(), Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 11/13] target/riscv: change vext_get_vlmax() arguments, Daniel Henrique Barboza, 2024/01/16
- [PATCH v3 12/13] trans_rvv.c.inc: use vext_get_vlmax() in trans_vrgather_v*(), Daniel Henrique Barboza, 2024/01/16