Re: [Acl-devel] [PATCH] add 64-bit Arm xattr syscall numbers

[Mike Frysinger]

On Monday 07 January 2013 09:20:34 Riku Voipio wrote:
> On 13 December 2012 11:35, Riku Voipio wrote:
> > On 12 December 2012 22:47, Mike Frysinger wrote:
> >> On Wednesday 12 December 2012 10:32:03 Riku Voipio wrote:
> >> > Applying this patch makes attr "make tests" pass on ext4 with Linux
> >> > 3.7 on the 64-Bit arm simulator.
> >> > 
> >> > Also, when making the next attr and acl release tarballs, make sure
> >> > you run
> >> > autoreconf autotools-dev 20120210.1 or later, to get aarch64 strings
> >> > in config.sub and config.guess
> >> 
> >> seems to me that this code is fundamentally taking the wrong approach. 
> >> it should just use SYS_xxx that sys/syscall.h already provides.
> > 
> > I guess the original approach originates from time when kernel headers
> > were more often broken than not for userspace. I've attached a new patch
> > that includes sys/syscall.h and removes the local defines. It passes the
> > testsuite on x86, x86_64, arm eabi and 64bit arm.
> 
> Actually the hardcoding of xattr syscalls was probably done because
> not everyone had new enough kernel headers with xattr syscall numbers
> defined. This is ofcourse long since gone problem - even the oldest
> still supported distributions like RHEL4 have these system calls
> provided by kernel headers.
> 
> Who can commit these changes to attr ?

i wish i knew ;).  we just hit this same bug in Gentoo, but with a much older 
arch -- parisc (hppa).
-mike

signature.asc
Description: This is a digitally signed message part.