[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Acl-devel] [PATCH] Fix minor issues found in getfacl.c

From: Jaska Uimonen
Subject: Re: [Acl-devel] [PATCH] Fix minor issues found in getfacl.c
Date: Tue, 08 Sep 2015 16:17:26 +0300
User-agent: Internet Messaging Program (IMP) H5 (6.1.6)

Yes, Andreas' modified patch looks better,
thank you both for responding.


Quoting Kamil Dudka <address@hidden>:

On Tuesday 08 September 2015 14:30:15 Andreas Grünbacher wrote:
Jaska and Kamil,

2015-09-08 14:26 GMT+02:00 Kamil Dudka <address@hidden>:
> On Tuesday 08 September 2015 14:37:56 Jaska Uimonen wrote:
>> Hi,
>> I was assigned to fix some static analysis issues
>> in my company. There we're couple identified in acl.
>> These are all in getfacl.c and are quite minor things,
>> but here they are anyway... they are mainly concerning
>> not freeing things returned from acl_get_identifier.


> Looks good to me.  I would personally prefer explicit type conversion when
> freeing id_p instead of changing its declaration

Or making the variable non-const in the first place.

That was already in the original patch by Jaska ;-)

Also I wouldprefer not to expand the life span of those temporary variables
too much.

Sounds like a good idea.

How about the attached fix?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]