auctex-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Showing compilation progress indicator


From: Arash Esbati
Subject: Re: Showing compilation progress indicator
Date: Tue, 09 Aug 2022 19:44:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50

Hi Al,

Arash Esbati <arash@gnu.org> writes:

> Al Haji-Ali <abdo.haji.ali@gmail.com> writes:
>
>> Thanks Arash for the suggestions. I implemented all of them.
>
> Thanks for considering my suggestions.  If I'm allowed to make another
> one, you have introduced
>
> (defcustom procress--auctex-process-start-hook nil
>   "A hook run after a TeX command process is started.
> Passes the handle to created process as the only argument."
>   :type 'hook
>   :group 'procress)

Sorry for bugging you again, but I missed this point in my last message.
You can drop the ":group 'procress" in your defcustom's.  From the lisp
reference[1]:

  15.1 Common Item Keywords

  :group group

      Put this customization item in group group.  If this keyword is
      missing from a customization item, it’ll be placed in the same group
      that was last defined (in the current file).

So the following patch should fix this:

--8<---------------cut here---------------start------------->8---
diff --git a/procress.el b/procress.el
index eac1ce0..c4af2dc 100644
--- a/procress.el
+++ b/procress.el
@@ -75,8 +75,7 @@ The car is the index used for the cdr.")

 (defcustom procress-click-hook nil
   "Hook run after clicking modeline string."
-  :type 'hook
-  :group 'procress)
+  :type 'hook)

 (defun procress-modeline-string ()
   "Return the modeline string containing the procress indicator."
@@ -145,8 +144,7 @@ the procress indicator will be hidden after

 (defcustom procress-hide-done-after 1
   "Seconds to show the procress indicator for success."
-  :type 'number
-  :group 'procress)
+  :type 'number)

 (defun procress--start-hide-timer ()
   "Start a timer to hide the procress indicator in the modeline."
@@ -254,20 +252,17 @@ the center. "
 (defcustom procress-auctex-process-start-hook nil
   "A hook run after a TeX command process is started.
 Passes the handle to created process as the only argument."
-  :type 'hook
-  :group 'procress)
+  :type 'hook)

 (defcustom procress-auctex-process-filter-hook nil
   "A hook run when the filtering function of TeX command process is called.
 Passes the process handle and newly outputted string."
-  :type 'hook
-  :group 'procress)
+  :type 'hook)

 (defcustom  procress-auctex-process-sentinel-hook nil
   "A hook run when the sentinel function of TeX command process is called.
 Passes the process handle and a status string."
-  :type 'hook
-  :group 'procress)
+  :type 'hook)

 (defun procress--auctex-run-command@advice (old-fn &rest args)
   (let ((process (apply old-fn args)))
--8<---------------cut here---------------end--------------->8---

Best, Arash

Footnotes:
[1]  
https://www.gnu.org/software/emacs/manual/html_node/elisp/Common-Keywords.html




reply via email to

[Prev in Thread] Current Thread [Next in Thread]