[patch #8186] ax_pthread adds -pthread when it should not on OSX when compiling with clang

[Daniel Richard G.]

Follow-up Comment #20, patch #8186 (project autoconf-archive):

Hi Heikki,

-D_REENTRANT and -D_THREAD_SAFE can be removed from your build scripts;
AX_PTHREAD now takes care of adding these to PTHREAD_CFLAGS on certain
platforms. It's possible that some platforms will then lose one/both of these
flags (do note that they can be defined implicitly by -mt et al.) but this is
correct behavior if the system headers do not make use of those cpp symbols.

-D_POSIX_PTHREAD_SEMANTICS is, of course, not handled by AX_PTHREAD. It
appears to be applicable only to Solaris. Should I add this to the
special-flags section of the macro?

The build farms logs are extraordinarily helpful! Thank you for running this
draft version through there!

I see a number of Clang builds now use no pthreads option flag at all (though
retaining -D flags). None of those builds broke, but please let me know if
there is any negative effect from dropping the options.

smew is running a fairly old version of Clang that my draft did not handle
correctly. I'm surprised that build didn't break. I've fixed the issue there.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8186>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/