Re: Valgrind check: No rule to make target 'check-TESTS'

[Sébastien Wilmet]

On Mon, Aug 01, 2016 at 03:02:05PM +0100, Philip Withnall wrote:
> I suspect you have added @VALGRIND_CHECK_RULES@ to
> $top_srcdir/Makefile.am, and are running `make check-valgrind-memcheck` 
> there. What you need to do instead is to add @VALGRIND_CHECK_RULES@ to
> $top_srcdir/testsuite/Makefile.am, and run `make -C testsuite check-
> valgrind-memcheck`.
> 
> check-TESTS should be defined in $top_builddir/testsuite/Makefile.in,
> but not in $top_builddir/Makefile.in, since you don’t have any tests
> defined there.

Thanks for the quick reply, it was indeed that. The doc at the top of
ax_valgrind_check.m4 is correct, but not the doc at:
https://developer.gnome.org/programming-guidelines/stable/tooling.html.en#valgrind

“3. Add @VALGRIND_CHECK_RULES to the top-level Makefile.am.”

(BTW a @ is missing at the end of VALGRIND_CHECK_RULES).

--
Sébastien