[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Noah Misch
Subject: Re: _AS_PATH_WALK
Date: Wed, 15 Mar 2006 08:03:57 -0800
User-agent: Mutt/1.5.6i

On Wed, Mar 15, 2006 at 12:47:11PM +0100, Stepan Kasal wrote:
> well, the following patch would save 170 bytes.

A space optimization of this magnitude is irrelevant at the scope of a configure
script.  Let us ignore this virtue.

> I think setting IFS and unsetting CDPATH is ``sanitizing''.

I agree with this part.

> And I think the stack of depth 1 (as_save_IFS) has no practical value;
> using a global default value is IMHO more sincere.

No other macro in m4sh uses this variable.  One would only run into trouble by
making an AS_PATH_WALK the BODY of another AS_PATH_WALK.  If preserving IFS has
any practical value at all, one-level preservation is not so bad. authors who change IFS should always revert it before calling
Autoconf macros, or any macros they do not control.  Nonetheless, this patch can
only break existing uses.  In the absence of other significant benefits, let us
forgo this change.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]