[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Stepan Kasal
Subject: Re: _AS_PATH_WALK
Date: Thu, 16 Mar 2006 14:35:32 +0100
User-agent: Mutt/1.4.1i


On Wed, Mar 15, 2006 at 05:30:43PM +0100, Ralf Wildenhues wrote:
> * Noah Misch wrote on Wed, Mar 15, 2006 at 05:03:57PM CET:

> > > I think setting IFS and unsetting CDPATH is ``sanitizing''.
> > 
> > I agree with this part.
> Agreed.

thank you for your reviews, I wasn't sure about that.

I marginally noticed the problem that

> Before the patch, IFS would be sanitized only after the first path walk

... but wasn't able to see the consequences.

> Second, your change to _AC_CANONICAL_SPLIT 

... would re-introduce an old bug.
Thank you, Ralf, for both explanations; I distilled them to two terse
comments, which I engraved there for future generations.

> > > And I think the stack of depth 1 (as_save_IFS) has no practical value;

> > [...] one-level preservation is not so bad. [...] this patch can only
> > break existing uses.  [...] let us forgot this change.

OK, let's forgot about it.

I committed the patch as attached here.

Have a nice day,

Attachment: autoconf-20060316-ifs.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]