Re: Remove the rest of the comment from _AC_CACHE_DUMP

[Stepan Kasal]

Hello,

On Mon, Apr 10, 2006 at 11:17:32AM +0200, Ralf Wildenhues wrote:
> For post-2.60, you could try to come up with a patch that uniquifies
> only the #define components and leaves all others intact, including
> order. [...]

``Uniquifies''?  Please note that there was no uniquification for all
the years.  (Paul added `sort -u' two days ago only to remove duplicate
_empty_ lines.)

Actually, we believe here that duplicate confdefs.h are unusual, because
from the sorted list you could not see the original order.
(Cf. with status.m4, which takes care to obey the last of duplicate
AC_DEFINEs.)

> For bonus points, you could sort all non-#if*-adorned defines.

I thought about that.  What if you have:

#ifdef FOO
#define FOO_EARLY 1
#endif
#define FOO 1
#ifdef FOO
#define FOO_LATE 1
#endif

Shall we sort the blocks between the occurences of #ifdef's?
That would make visual searching really confusing!

So after all, I see two possibilities:
1) cat confdefs.h
2) sort confdefs.h and change the AS_BOXed title to ``confdefs.h (sorted)''

Paul has just committed 1).  This presents a regression, though only a visual
one.  I'm afraid it was a mistake to do this now, while we are in ``freeze''.

I would suggest the following instead.
OK to commit?

Have a nice day,
        Stepan

autoconf-20060410-sorted.patch
Description: Text document