[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: make check hangs on test 93 under Sun Solaris 9

From: Ralf Wildenhues
Subject: Re: make check hangs on test 93 under Sun Solaris 9
Date: Wed, 7 Feb 2007 19:58:18 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

Hello Paul,

Thanks for your patch.

* Paul Eggert wrote on Wed, Feb 07, 2007 at 06:48:27PM CET:
> Also, the bare CR should be put into a separate variable so that
> the problem occurs only once.


> Also, we should prefer \r.  I don't know of any Awk in modern use
> that doesn't support \r -- does anyone else?  V7 awk didn't support \r
> but it got added a long time ago.

Ah, good.  I didn't know.

> Also, the current test for CR etc. fails on Solaris 8 due to a bug in
> Bash 2.03 printf (which is standard on Solaris 8).


> I installed this.  Most likely the CR will be hosed in this patch
> too, but you can look at CVS to see what it is.

Looks good to me except for this one bit:

> @@ -524,7 +529,7 @@ cat >>"\$tmp/subs1.awk" <<CEOF
>  ]m4_ifdef([_AC_SUBST_FILES],
>  [\$ac_cs_awk_pipe_fini])[
> -sed "s,
> $,,; s,
> ,\$ac_cs_awk_cr&,g" < "\$tmp/subs1.awk" > "\$tmp/subs.awk"
> +sed 's/$ac_cr\$//; s/$ac_cr/$ac_cs_awk_cr/g' < "\$tmp/subs1.awk" > 
> "\$tmp/subs.awk"
>  ]dnl end of double-quoted part

At configure time, this is inside a non-literal here-document (i.e.,
`<<_ACEOF' was not quoted, thus expansions apply).  Thus $ac_cr will
be expanded by configure: to nothing, as $ac_cr is only set at
config.status time.  The way things are, we want no expansion at
configure time and expansion at config.status time.

Is the following patch ok (including a regenerate of autoconf/configure)
or should I also rename the variable to ac_cs_cr for clarity?


2007-02-07  Ralf Wildenhues  <address@hidden>

        * lib/autoconf/status.m4 (_AC_OUTPUT_FILES_PREPARE): Fix quoting
        error introduced in last change.

Index: lib/autoconf/status.m4
RCS file: /cvsroot/autoconf/autoconf/lib/autoconf/status.m4,v
retrieving revision 1.129
diff -u -r1.129 status.m4
--- lib/autoconf/status.m4      7 Feb 2007 17:45:37 -0000       1.129
+++ lib/autoconf/status.m4      7 Feb 2007 18:55:50 -0000
@@ -529,7 +529,7 @@
-sed 's/$ac_cr\$//; s/$ac_cr/$ac_cs_awk_cr/g' < "\$tmp/subs1.awk" > 
+sed "s/\$ac_cr\$//; s/\$ac_cr/\$ac_cs_awk_cr/g" < "\$tmp/subs1.awk" > 
 ]dnl end of double-quoted part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]