[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unbreak Cygwin bash igncr mode with ac_cr

From: Aaron W. LaFramboise
Subject: Re: Unbreak Cygwin bash igncr mode with ac_cr
Date: Sun, 22 Mar 2009 01:06:58 -0500
User-agent: Thunderbird (Windows/20090302)

Aaron W. LaFramboise wrote:
Aaron W. LaFramboise wrote:

But yes, like Ralf suggested, I'd be interested in your testsuite results
with and without igncr and/or a patch along these lines.

I'm sorry to take so long to get back to you, but the testsuite takes a very long time to run on Cygwin, and more urgent business pushed this onto the back burner.

Please see the attached patch, which as far as I know, should only activate if igncr or something like it is in use. Note it uses a bash extension, as discussed previously, but since only bash has igncr, I think this is OK.

Here are the testsuite results as of January 2009's 2.63.252-8aa9.

1) No igncr, no patch
  393 tests were successful.
  3 tests were skipped.

2) No igncr, with patch
  393 tests were successful.
  3 tests were skipped.

3) With igncr enabled, no patch
  autoconf fails to build, due to this issue

4) With igncr enabled, patch
  Build successful.
  Testsuite hangs forever at
    27. autom4te preselections

I'm sorry that I've waited this long to report on this issue, as now even more packages are being released with versions of autoconf incompatible with igncr, many of the same packages that will only build on Cygwin with Windows native tools (which produce trailing carriage returns) with igncr enabled.

I know it would be ideal to analyze the igncr testsuite issues, but its so bleeding slow and I don't really have a lot of resources available to work on this problem. What do you guys think?
2008-01-08  Aaron W. LaFramboise  <address@hidden>

        * lib/autoconf/status.m4 (ac_cr): Fall back to bash carriage returns
        if necessary.

diff --git a/lib/autoconf/status.m4 b/lib/autoconf/status.m4
index bfd7a79..b8f8c00 100644
--- a/lib/autoconf/status.m4
+++ b/lib/autoconf/status.m4
@@ -376,6 +376,9 @@ else
   ac_cs_awk_pipe_fini='END { print "|#_!!_#|"; print ":" }'
 ac_cr=`echo X | tr X '\015'`
+if test "x$ac_cr" = x; then
+  eval ac_cr=\$\'\\r\'
 ac_cs_awk_cr=`$AWK 'BEGIN { print "a\rb" }' </dev/null 2>/dev/null`
 if test "$ac_cs_awk_cr" = "a${ac_cr}b"; then

reply via email to

[Prev in Thread] Current Thread [Next in Thread]