[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unbreak Cygwin bash igncr mode with ac_cr

From: Ralf Wildenhues
Subject: Re: Unbreak Cygwin bash igncr mode with ac_cr
Date: Sun, 22 Mar 2009 08:23:31 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

Hello Aaron,

* Aaron W. LaFramboise wrote on Sun, Mar 22, 2009 at 07:06:58AM CET:
> I'm sorry to take so long to get back to you, but the testsuite takes a  
> very long time to run on Cygwin, and more urgent business pushed this  
> onto the back burner.

No problem at all, of course.

> Please see the attached patch, which as far as I know, should only  
> activate if igncr or something like it is in use.  Note it uses a bash  
> extension, as discussed previously, but since only bash has igncr, I  
> think this is OK.

Hmm.  There has meanwhile been another proposed patch to fix a similar
build failure on DJGPP:

Could you try it out, please, without any other patches?  Sorry for
making you run the testsuite yet another time.

> Here are the testsuite results as of January 2009's 2.63.252-8aa9.
> 1) No igncr, no patch
>   393 tests were successful.
>   3 tests were skipped.
> 2) No igncr, with patch
>   393 tests were successful.
>   3 tests were skipped.
> 3) With igncr enabled, no patch
>   autoconf fails to build, due to this issue
> 4) With igncr enabled, patch
>   Build successful.
>   Testsuite hangs forever at
>     27. autom4te preselections

In (2) and (4), which patch would that be, the one you posted in
or the one you just posted below (that is, in
With the patch below, I'd fear that some weird shell could fail to parse
the "$'" even if it were to ignore that branch of execution.  I don't
know of any, though.

> I know it would be ideal to analyze the igncr testsuite issues, but its  
> so bleeding slow and I don't really have a lot of resources available to  
> work on this problem.  What do you guys think?

For a failure, just post tests/testsuite.log.  For a hang, just run
something like
  make check TESTSUITEFLAGS='-v -d -x 27'

which just runs test 27 verbosely, and post where it hangs.  You can
also use ranges '30-40' to run several tests.


> 2008-01-08  Aaron W. LaFramboise  <address@hidden>
>       * lib/autoconf/status.m4 (ac_cr): Fall back to bash carriage returns
>       if necessary.
> diff --git a/lib/autoconf/status.m4 b/lib/autoconf/status.m4
> index bfd7a79..b8f8c00 100644
> --- a/lib/autoconf/status.m4
> +++ b/lib/autoconf/status.m4
> @@ -376,6 +376,9 @@ else
>    ac_cs_awk_pipe_fini='END { print "|#_!!_#|"; print ":" }'
>  fi]])
>  ac_cr=`echo X | tr X '\015'`
> +if test "x$ac_cr" = x; then
> +  eval ac_cr=\$\'\\r\'
> +fi
>  ac_cs_awk_cr=`$AWK 'BEGIN { print "a\rb" }' </dev/null 2>/dev/null`
>  if test "$ac_cs_awk_cr" = "a${ac_cr}b"; then
>    ac_cs_awk_cr='\\r'

reply via email to

[Prev in Thread] Current Thread [Next in Thread]